From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751578AbdFGNlg (ORCPT ); Wed, 7 Jun 2017 09:41:36 -0400 Received: from mail.fastquake.com ([45.33.83.177]:40296 "EHLO mail.fastquake.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751403AbdFGNlf (ORCPT ); Wed, 7 Jun 2017 09:41:35 -0400 Date: Wed, 7 Jun 2017 13:41:31 +0000 From: John Brooks To: Joe Perches Cc: Andrew Morton , Andy Whitcroft , linux-kernel@vger.kernel.org Subject: Re: [PATCH V3] checkpatch: Change format of --color argument to --color[=WHEN] Message-ID: <20170607134131.GA19794@kitsune.fastquake.com> References: <1496779410.1968.32.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 06, 2017 at 06:50:06PM -0700, Joe Perches wrote: > From: John Brooks > > The boolean --color argument did not offer the ability to force colourized > output even if stdout is not a terminal. Change the format of the argument > to the familiar --color[=WHEN] construct as seen in common Linux utilities > such as git, ls and dmesg, which allows the user to specify whether to > colourize output "always", "never", or "auto" when the output is a terminal. > The default is "auto". > > The old command-line uses of --color and --no-color are unchanged. > > Signed-off-by: John Brooks > Signed-off-by: Joe Perches Thanks for doing the V3 for me :) I was going to but had other work to do last night. John