From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751724AbdFGPCL (ORCPT ); Wed, 7 Jun 2017 11:02:11 -0400 Received: from foss.arm.com ([217.140.101.70]:33816 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751882AbdFGO7A (ORCPT ); Wed, 7 Jun 2017 10:59:00 -0400 Date: Wed, 7 Jun 2017 15:58:55 +0100 From: Catalin Marinas To: Punit Agrawal Cc: will.deacon@arm.com, David Woods , steve.capper@arm.com, tbaicar@codeaurora.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, manoj.iyer@canonical.com Subject: Re: [PATCH v2 1/3] arm64: hugetlb: Fix huge_pte_offset to return poisoned page table entries Message-ID: <20170607145855.cu5tob2uck2xbvxm@localhost> References: <20170517152336.6052-1-punit.agrawal@arm.com> <20170517152336.6052-2-punit.agrawal@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170517152336.6052-2-punit.agrawal@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 17, 2017 at 04:23:34PM +0100, Punit Agrawal wrote: > When memory failure is enabled, a poisoned hugepage pte is marked as a > swap entry. huge_pte_offset() does not return the poisoned page table > entries when it encounters PUD/PMD hugepages. > > This behaviour of huge_pte_offset() leads to error such as below when > munmap is called on poisoned hugepages. > > [ 344.165544] mm/pgtable-generic.c:33: bad pmd 000000083af00074. > > Fix huge_pte_offset() to return the poisoned pte which is then > appropriately handled by the generic layer code. > > Signed-off-by: Punit Agrawal > Acked-by: Steve Capper > Cc: Catalin Marinas > Cc: David Woods Since the patch matches my suggestions in v1: Reviewed-by: Catalin Marinas