From: Matthias Kaehlcke <mka@chromium.org>
To: David Rientjes <rientjes@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Steven Rostedt <rostedt@goodmis.org>,
Douglas Anderson <dianders@chromium.org>,
Guenter Roeck <linux@roeck-us.net>,
Mark Brown <broonie@kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: [patch] compiler, clang: move inline definition to compiler-gcc.h
Date: Wed, 7 Jun 2017 09:41:38 -0700 [thread overview]
Message-ID: <20170607164138.GB141096@google.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1706062252500.124004@chino.kir.corp.google.com>
El Tue, Jun 06, 2017 at 10:56:49PM -0700 David Rientjes ha dit:
> The motivation of commit abb2ea7dfd82 ("compiler, clang: suppress warning
> for unused static inline functions") is to suppress clang's warnings about
> unused static inline functions.
>
> Clang defines __GNUC__ so it inherits all of compiler-gcc.h as well, so
> the redefinition of `inline' ends up overriding the definition in
> compiler-gcc.h.
>
> Simply annotate all inline functions as __attribute__((unused)). It's
> necessary to suppress the warning for clang and is implicit with gcc.
>
> Reported-by: Matthias Kaehlcke <mka@chromium.org>
> Signed-off-by: David Rientjes <rientjes@google.com>
> ---
Tested-by: Matthias Kaehlcke <mka@chromium.org>
prev parent reply other threads:[~2017-06-07 16:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 5:56 [patch] compiler, clang: move inline definition to compiler-gcc.h David Rientjes
2017-06-07 16:41 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607164138.GB141096@google.com \
--to=mka@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mingo@kernel.org \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox