From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751632AbdFGQ76 (ORCPT ); Wed, 7 Jun 2017 12:59:58 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:35349 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751260AbdFGQ74 (ORCPT ); Wed, 7 Jun 2017 12:59:56 -0400 Date: Wed, 7 Jun 2017 09:59:53 -0700 From: Dmitry Torokhov To: Benjamin Tissoires Cc: linux-input@vger.kernel.org, Andrew Duggan , Lyude Paul , Damjan Georgievski , Masaki Ota , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: synaptics_rmi4 - register F03 port as pass-through serio Message-ID: <20170607165953.GB13116@dtor-ws> References: <20170607065128.GA31686@dtor-ws> <20170607070255.GA16591@mail.corp.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170607070255.GA16591@mail.corp.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 07, 2017 at 09:02:55AM +0200, Benjamin Tissoires wrote: > On Jun 06 2017 or thereabouts, Dmitry Torokhov wrote: > > The 5th generation Thinkpad X1 Carbons use Synaptics touchpads accessible > > over SMBus/RMI, combined with ALPS or Elantech trackpoint devices instead > > of classic IBM/Lenovo trackpoints. Unfortunately there is no way for ALPS > > driver to detect whether it is dealing with touchpad + trackpoint > > combination or just a trackpoint, so we end up with a "phantom" dualpoint > > ALPS device in addition to real touchpad and trackpoint. > > > > Given that we do not have any special advanced handling for ALPS or > > Elantech trackpoints (unlike IBM trackpoints that have separate driver and > > a host of options) we are better off keeping the trackpoints in PS/2 > > emulation mode. We achieve that by setting serio type to SERIO_PS_PSTHRU, > > which will limit number of protocols psmouse driver will try. In addition > > to getting rid of the "phantom" touchpads, this will also speed up probing > > of F03 pass-through port. > > > > Reported-by: Damjan Georgievski > > Suggested-by: Benjamin Tissoires > > Signed-off-by: Dmitry Torokhov > > --- > > Thanks for the extensive commit message :) > > Acked-by: Benjamin Tissoires Thanks Benjamin. Damjan, could you please try this patch too before I send it Linus-wards. > > (tested on a t450s without problems). > > Cheers, > Benjamin > > > drivers/input/rmi4/rmi_f03.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/input/rmi4/rmi_f03.c b/drivers/input/rmi4/rmi_f03.c > > index 77dad045a468..ad71a5e768dc 100644 > > --- a/drivers/input/rmi4/rmi_f03.c > > +++ b/drivers/input/rmi4/rmi_f03.c > > @@ -146,7 +146,7 @@ static int rmi_f03_register_pt(struct f03_data *f03) > > if (!serio) > > return -ENOMEM; > > > > - serio->id.type = SERIO_8042; > > + serio->id.type = SERIO_PS_PSTHRU; > > serio->write = rmi_f03_pt_write; > > serio->port_data = f03; > > > > -- > > 2.13.0.506.g27d5fe0cd-goog > > > > > > -- > > Dmitry -- Dmitry