From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751624AbdFGWXL (ORCPT ); Wed, 7 Jun 2017 18:23:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:57328 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751422AbdFGWXJ (ORCPT ); Wed, 7 Jun 2017 18:23:09 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A3DE239AC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Wed, 7 Jun 2017 19:23:05 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , kernel-team@lge.com, David Ahern , Adrian Hunter , Wang Nan Subject: Re: [PATCH v3 3/6] perf tools: Decompress kernel module when reading DSO data Message-ID: <20170607222305.GA6949@kernel.org> References: <20170607153903.1114-1-namhyung@kernel.org> <20170607153903.1114-4-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170607153903.1114-4-namhyung@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Jun 08, 2017 at 12:39:00AM +0900, Namhyung Kim escreveu: > Currently perf decompresses kernel modules when loading symbol table but > it missed to do it when reading raw data. > > Signed-off-by: Namhyung Kim > --- > tools/perf/util/dso.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c > index 59257ce4580e..2a0c689227f8 100644 > --- a/tools/perf/util/dso.c > +++ b/tools/perf/util/dso.c > @@ -463,8 +463,22 @@ static int __open_dso(struct dso *dso, struct machine *machine) > return -EINVAL; > } > > - if (!is_regular_file(name)) > + if (!is_regular_file(name)) { > + free(name); > return -EINVAL; > + } Humm, this looks like something for a separate patch? Its a pre-existing leak, separate issue. That error path in __open_dso() could be consolidated, but the above hunk is the minimal fix for perf/urgent, where I think your series should go from what I've read so far, agreed? - Arnaldo > + > + if (dso__needs_decompress(dso)) { > + char newpath[KMOD_DECOMP_LEN]; > + size_t len = sizeof(newpath); > + > + if (dso__decompress_kmodule_path(dso, name, newpath, len) < 0) { > + free(name); > + return -1; > + } > + > + strcpy(name, newpath); > + } > > fd = do_open(name); > free(name); > -- > 2.13.0