From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751730AbdFGWZZ (ORCPT ); Wed, 7 Jun 2017 18:25:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:57954 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751422AbdFGWZY (ORCPT ); Wed, 7 Jun 2017 18:25:24 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7848D239AC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Wed, 7 Jun 2017 19:25:20 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , kernel-team@lge.com, David Ahern , Adrian Hunter , Wang Nan Subject: Re: [PATCH v3 4/6] perf test: Decompress kernel module before objdump Message-ID: <20170607222520.GB6949@kernel.org> References: <20170607153903.1114-1-namhyung@kernel.org> <20170607153903.1114-5-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170607153903.1114-5-namhyung@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Jun 08, 2017 at 12:39:01AM +0900, Namhyung Kim escreveu: > If a kernel modules is compressed, it should be decompressed before > running objdump to parse binary data correctly. This fixes a failure of > object code reading test for me. > > Signed-off-by: Namhyung Kim > --- > tools/perf/tests/code-reading.c | 20 +++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/tests/code-reading.c b/tools/perf/tests/code-reading.c > index 1f14e7612cbb..94b7c7b02bde 100644 > --- a/tools/perf/tests/code-reading.c > +++ b/tools/perf/tests/code-reading.c > @@ -229,6 +229,8 @@ static int read_object_code(u64 addr, size_t len, u8 cpumode, > unsigned char buf2[BUFSZ]; > size_t ret_len; > u64 objdump_addr; > + const char *objdump_name; > + char decomp_name[KMOD_DECOMP_LEN]; > int ret; > > pr_debug("Reading object code for memory address: %#"PRIx64"\n", addr); > @@ -289,9 +291,25 @@ static int read_object_code(u64 addr, size_t len, u8 cpumode, > state->done[state->done_cnt++] = al.map->start; > } > > + objdump_name = al.map->dso->long_name; > + if (dso__needs_decompress(al.map->dso)) { > + if (dso__decompress_kmodule_path(al.map->dso, objdump_name, > + decomp_name, > + sizeof(decomp_name)) < 0) { > + pr_debug("decompression failed\n"); This is a too vague message, to help with debugging I suggest printing more detauls such as the file being decompressed and perhaps the decomp_name as well. - Arnaldo > + return -1; > + } > + > + objdump_name = decomp_name; > + } > + > /* Read the object code using objdump */ > objdump_addr = map__rip_2objdump(al.map, al.addr); > - ret = read_via_objdump(al.map->dso->long_name, objdump_addr, buf2, len); > + ret = read_via_objdump(objdump_name, objdump_addr, buf2, len); > + > + if (dso__needs_decompress(al.map->dso)) > + unlink(objdump_name); > + > if (ret > 0) { > /* > * The kernel maps are inaccurate - assume objdump is right in > -- > 2.13.0