From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753337AbdFGXfi (ORCPT ); Wed, 7 Jun 2017 19:35:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:38192 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752015AbdFGXfg (ORCPT ); Wed, 7 Jun 2017 19:35:36 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD5DF23958 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Wed, 7 Jun 2017 20:35:23 -0300 From: Arnaldo Carvalho de Melo To: SeongJae Park Cc: peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] perf-script-python.txt: Fix wrong code snippets Message-ID: <20170607233523.GF6949@kernel.org> References: <20170530111827.21732-1-sj38.park@gmail.com> <20170530111827.21732-5-sj38.park@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170530111827.21732-5-sj38.park@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, May 30, 2017 at 08:18:26PM +0900, SeongJae Park escreveu: > This commit fixes wrong code snippets for trace_begin() and trace_end() > function example definition. Fixed, and using: git log --follow tools/perf/Documentation/perf-script-python.txt Added the Fixes: tag: Fixes: cff68e582237 ("perf/scripts: Add perf-trace-python Documentation") And since you're taking the time to add the Fixes tag (yay, great!) please also add Cc: entries for the patch author and committer, in that case: Cc: Tom Zanussi Cc: Frederic Weisbecker I did it this time, using a script I have: [acme@jouet linux]$ cat ~/bin/fixes #!/bin/bash cset=$1 if [ $# -eq 0 ] ; then read cset fi git show --pretty=fuller $cset | grep '^\(Author\|Commit\): ' | sed -r 's/.*: +/Cc: /g' echo Fixes: `git one $cset` [acme@jouet linux]$ Just get the cset, in vim, and select it, pressing Shift+V while the cursor is on top of the cset id and then press : and finally !fixes + ENTER :) cff68e582237 - Arnaldo > Signed-off-by: SeongJae Park > --- > tools/perf/Documentation/perf-script-python.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/Documentation/perf-script-python.txt b/tools/perf/Documentation/perf-script-python.txt > index 44e51351536f..f723ce41268c 100644 > --- a/tools/perf/Documentation/perf-script-python.txt > +++ b/tools/perf/Documentation/perf-script-python.txt > @@ -530,7 +530,7 @@ can implement a set of optional functions: > gives scripts a chance to do setup tasks: > > ---- > -def trace_begin: > +def trace_begin(): > pass > ---- > > @@ -539,7 +539,7 @@ def trace_begin: > as display results: > > ---- > -def trace_end: > +def trace_end(): > pass > ---- > > -- > 2.13.0