From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751870AbdFHAhq (ORCPT ); Wed, 7 Jun 2017 20:37:46 -0400 Received: from LGEAMRELO12.lge.com ([156.147.23.52]:53888 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751049AbdFHAhp (ORCPT ); Wed, 7 Jun 2017 20:37:45 -0400 X-Original-SENDERIP: 156.147.1.121 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 10.177.227.17 X-Original-MAILFROM: namhyung@kernel.org Date: Thu, 8 Jun 2017 09:37:37 +0900 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , kernel-team@lge.com, David Ahern , Adrian Hunter , Wang Nan Subject: Re: [PATCH v3 4/6] perf test: Decompress kernel module before objdump Message-ID: <20170608003737.GC2116@sejong> References: <20170607153903.1114-1-namhyung@kernel.org> <20170607153903.1114-5-namhyung@kernel.org> <20170607222520.GB6949@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170607222520.GB6949@kernel.org> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 07, 2017 at 07:25:20PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Jun 08, 2017 at 12:39:01AM +0900, Namhyung Kim escreveu: > > If a kernel modules is compressed, it should be decompressed before > > running objdump to parse binary data correctly. This fixes a failure of > > object code reading test for me. > > > > Signed-off-by: Namhyung Kim > > --- > > tools/perf/tests/code-reading.c | 20 +++++++++++++++++++- > > 1 file changed, 19 insertions(+), 1 deletion(-) > > > > diff --git a/tools/perf/tests/code-reading.c b/tools/perf/tests/code-reading.c > > index 1f14e7612cbb..94b7c7b02bde 100644 > > --- a/tools/perf/tests/code-reading.c > > +++ b/tools/perf/tests/code-reading.c > > @@ -229,6 +229,8 @@ static int read_object_code(u64 addr, size_t len, u8 cpumode, > > unsigned char buf2[BUFSZ]; > > size_t ret_len; > > u64 objdump_addr; > > + const char *objdump_name; > > + char decomp_name[KMOD_DECOMP_LEN]; > > int ret; > > > > pr_debug("Reading object code for memory address: %#"PRIx64"\n", addr); > > @@ -289,9 +291,25 @@ static int read_object_code(u64 addr, size_t len, u8 cpumode, > > state->done[state->done_cnt++] = al.map->start; > > } > > > > + objdump_name = al.map->dso->long_name; > > + if (dso__needs_decompress(al.map->dso)) { > > + if (dso__decompress_kmodule_path(al.map->dso, objdump_name, > > + decomp_name, > > + sizeof(decomp_name)) < 0) { > > + pr_debug("decompression failed\n"); > > This is a too vague message, to help with debugging I suggest printing > more detauls such as the file being decompressed and perhaps the > decomp_name as well. Looking at the code, it already printed the filename so current message seems ok. $ sudo perf test -v 'code reading' 22: Object code reading : --- start --- ... Reading object code for memory address: 0xffffffffa0305c56 File is: /lib/modules/4.11.3-1-ARCH/kernel/fs/btrfs/btrfs.ko.gz On file address is: 0x61cc6 decompression failed test child finished with -1 ---- end ---- Object code reading: FAILED! Thanks, Namhyung