From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751642AbdFHGrC (ORCPT ); Thu, 8 Jun 2017 02:47:02 -0400 Received: from LGEAMRELO12.lge.com ([156.147.23.52]:34232 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751450AbdFHGrB (ORCPT ); Thu, 8 Jun 2017 02:47:01 -0400 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.220.163 X-Original-MAILFROM: minchan@kernel.org Date: Thu, 8 Jun 2017 15:46:58 +0900 From: Minchan Kim To: zhongjiang Cc: akpm@linux-foundation.org, vinayakm.list@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: correct the comment when reclaimed pages exceed the scanned pages Message-ID: <20170608064658.GA9190@bbox> References: <1496824266-25235-1-git-send-email-zhongjiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1496824266-25235-1-git-send-email-zhongjiang@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 07, 2017 at 04:31:06PM +0800, zhongjiang wrote: > The commit e1587a494540 ("mm: vmpressure: fix sending wrong events on > underflow") declare that reclaimed pages exceed the scanned pages due > to the thp reclaim. it is incorrect because THP will be spilt to normal > page and loop again. which will result in the scanned pages increment. > > Signed-off-by: zhongjiang > --- > mm/vmpressure.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/vmpressure.c b/mm/vmpressure.c > index 6063581..0e91ba3 100644 > --- a/mm/vmpressure.c > +++ b/mm/vmpressure.c > @@ -116,8 +116,9 @@ static enum vmpressure_levels vmpressure_calc_level(unsigned long scanned, > > /* > * reclaimed can be greater than scanned in cases > - * like THP, where the scanned is 1 and reclaimed > - * could be 512 > + * like reclaimed slab pages, shrink_node just add > + * reclaimed page without a related increment to > + * scanned pages. > */ > if (reclaimed >= scanned) > goto out; Thanks for the fixing my fault! Acked-by: Minchan Kim Frankly speaking, I'm not sure we need such comment in there at the cost of maintainance because it would be fragile but easy to fix by above simple condition so I think it would be better to remove that comment but others might be different. So, don't have any objection.