From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751608AbdFHHl1 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 8 Jun 2017 03:41:27 -0400
Received: from verein.lst.de ([213.95.11.211]:57412 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751035AbdFHHl0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 8 Jun 2017 03:41:26 -0400
Date: Thu, 8 Jun 2017 09:41:24 +0200
From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
        Keith Busch <keith.busch@intel.com>, Hannes Reinecke <hare@suse.de>,
        Max Gurtovoy <maxg@mellanox.com>,
        Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
        Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 01/10] scatterlist: add sg_zeroout_area() helper
Message-ID: <20170608074124.GA13953@lst.de>
References: <20170607094536.32419-1-jthumshirn@suse.de> <20170607094536.32419-2-jthumshirn@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170607094536.32419-2-jthumshirn@suse.de>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>  size_t sg_pcopy_to_buffer(struct scatterlist *sgl, unsigned int nents,
>  			  void *buf, size_t buflen, off_t skip);
>  
> +size_t sg_zeroout_area(struct scatterlist *sgl, unsigned int nents,
> +		       size_t buflen, off_t skip);

Maybe sg_zero_buffer to fit with the other functions in the family?

(I'd be happy to fix this up if you're ok and we don't need another
respin otherwise).

> +	while ((offset < buflen) && sg_miter_next(&miter)) {

Nit: no need for the inner braces.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>