From: Luca Abeni <luca.abeni@santannapisa.it>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Juri Lelli <juri.lelli@arm.com>,
Claudio Scordino <claudio@evidence.eu.com>,
Steven Rostedt <rostedt@goodmis.org>,
Tommaso Cucinotta <tommaso.cucinotta@sssup.it>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Joel Fernandes <joelaf@google.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Luca Abeni <luca.abeni@unitn.it>
Subject: Re: [PATCH 01/10] sched/deadline: track the active utilization
Date: Thu, 8 Jun 2017 10:43:22 +0200 [thread overview]
Message-ID: <20170608104322.060b9139@luca> (raw)
In-Reply-To: <20170608083125.6cum2zoklnzi2mbx@gmail.com>
On Thu, 8 Jun 2017 10:31:25 +0200
Ingo Molnar <mingo@kernel.org> wrote:
> * luca abeni <luca.abeni@santannapisa.it> wrote:
>
> > From: Luca Abeni <luca.abeni@unitn.it>
> >
> > Active utilization is defined as the total utilization of active
> > (TASK_RUNNING) tasks queued on a runqueue. Hence, it is increased
> > when a task wakes up and is decreased when a task blocks.
> >
> > When a task is migrated from CPUi to CPUj, immediately subtract the
> > task's utilization from CPUi and add it to CPUj. This mechanism is
> > implemented by modifying the pull and push functions.
> > Note: this is not fully correct from the theoretical point of view
> > (the utilization should be removed from CPUi only at the 0 lag
> > time), a more theoretically sound solution is presented in the
> > next patches.
> >
> > Signed-off-by: Juri Lelli <juri.lelli@arm.com>
> > Signed-off-by: Luca Abeni <luca.abeni@unitn.it>
> > Tested-by: Daniel Bristot de Oliveira <bristot@redhat.com>
>
> So that SOB chain is not valid - either Juri needs to be the From:
> author, or it should be an Acked-by (or Reviewed-by).
>
> For now I've converted this to:
>
> > Signed-off-by: Luca Abeni <luca.abeni@unitn.it>
> > Acked-by: Juri Lelli <juri.lelli@arm.com>
Sorry, my fault: I must have misunderstood how to use the Signed-off-by
stuff.
The story here is that I took a patch originally developed by Juri and
fixed and I heavily modified it. Since the current patch is very
different from the original one, Juri suggested I should by the "From:"
author, and I simply added his Signed-off-by to acknowledge that he was
the author of the original patch.
If Juri is ok with your change, I agree with it.
Thanks,
Luca
next prev parent reply other threads:[~2017-06-08 8:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 20:13 [PATCH 00/10] CPU reclaiming for SCHED_DEADLINE luca abeni
2017-05-18 20:13 ` [PATCH 01/10] sched/deadline: track the active utilization luca abeni
2017-06-08 8:31 ` Ingo Molnar
2017-06-08 8:43 ` Luca Abeni [this message]
2017-06-08 9:05 ` Juri Lelli
2017-06-08 13:36 ` Steven Rostedt
2017-06-08 13:47 ` Juri Lelli
2017-06-08 9:23 ` [tip:sched/core] sched/deadline: Track " tip-bot for Luca Abeni
2017-05-18 20:13 ` [PATCH 02/10] sched/deadline: improve the tracking of " luca abeni
2017-06-08 9:24 ` [tip:sched/core] sched/deadline: Improve " tip-bot for Luca Abeni
2017-05-18 20:13 ` [PATCH 03/10] sched/deadline: fix the update of the total -deadline utilization luca abeni
2017-06-08 9:24 ` [tip:sched/core] sched/deadline: Fix " tip-bot for Luca Abeni
2017-05-18 20:13 ` [PATCH 04/10] sched/deadline: implement GRUB accounting luca abeni
2017-06-08 9:25 ` [tip:sched/core] sched/deadline: Implement " tip-bot for Luca Abeni
2017-05-18 20:13 ` [PATCH 05/10] sched/deadline: do not reclaim the whole CPU bandwidth luca abeni
2017-06-08 9:25 ` [tip:sched/core] sched/deadline: Do " tip-bot for Luca Abeni
2017-05-18 20:13 ` [PATCH 06/10] sched/deadline: make GRUB a task's flag luca abeni
2017-06-08 9:26 ` [tip:sched/core] sched/deadline: Make " tip-bot for Luca Abeni
2017-05-18 20:13 ` [PATCH 07/10] sched/deadline: track the "total rq utilization" too luca abeni
2017-06-08 9:26 ` [tip:sched/core] sched/deadline: Track " tip-bot for Luca Abeni
2017-05-18 20:13 ` [PATCH 08/10] sched/deadline: base GRUB reclaiming on the inactive utilization luca abeni
2017-06-08 9:27 ` [tip:sched/core] sched/deadline: Base " tip-bot for Luca Abeni
2017-05-18 20:13 ` [PATCH 09/10] sched/deadline: also reclaim bandwidth not used by dl tasks luca abeni
2017-06-08 9:28 ` [tip:sched/core] sched/deadline: Reclaim " tip-bot for Luca Abeni
2017-05-18 20:13 ` [PATCH 10/10] sched/deadline: documentation about GRUB reclaiming luca abeni
2017-06-08 9:28 ` [tip:sched/core] sched/deadline: Add " tip-bot for Claudio Scordino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170608104322.060b9139@luca \
--to=luca.abeni@santannapisa.it \
--cc=bristot@redhat.com \
--cc=claudio@evidence.eu.com \
--cc=joelaf@google.com \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@unitn.it \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tommaso.cucinotta@sssup.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox