From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751965AbdFHNoq (ORCPT ); Thu, 8 Jun 2017 09:44:46 -0400 Received: from mail-wr0-f175.google.com ([209.85.128.175]:34228 "EHLO mail-wr0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751712AbdFHN0u (ORCPT ); Thu, 8 Jun 2017 09:26:50 -0400 Date: Thu, 8 Jun 2017 15:26:40 +0200 From: Daniel Lezcano To: Arnd Bergmann Cc: Joel Stanley , Andrew Jeffery , Linux ARM , Linux Kernel Mailing List , Linus Walleij Subject: Re: [PATCH] arm: aspeed: Add clock-names property to timer node Message-ID: <20170608132640.GD2244@mai> References: <20170605074846.30925-1-andrew@aj.id.au> <20170607125256.GG2345@mai> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 07, 2017 at 04:29:50PM +0200, Arnd Bergmann wrote: > On Wed, Jun 7, 2017 at 2:52 PM, Daniel Lezcano > wrote: > > On Tue, Jun 06, 2017 at 11:41:11AM +0200, Arnd Bergmann wrote: > >> On Mon, Jun 5, 2017 at 10:59 AM, Joel Stanley wrote: > >> > On Mon, Jun 5, 2017 at 5:18 PM, Andrew Jeffery wrote: > >> >> The merging of a number of clocksource drivers into fttmr010 means we > >> >> require clock-names to be specified in the Aspeed timer node, else the > >> >> clocksource fails to probe and boot hangs. > >> > > >> > Arnd, > >> > > >> > Linus' reworked timer driver will go into 4.13. > >> > > >> > Can we get this patch merged into 4.12 as a fix so we don't end up > >> > with a broken boot at any stage? > >> > >> Hmm, can't we make the driver backward-compatible and have it fall > >> back on the first clock if no clk named "PCLK" is found? Otherwise > >> you still have an incompatible change in the DT binding and it will > >> break if someone uses an older dtb with a newer kernel. > > > > I would like to avoid to hack the kernel code for backward DT compatible > > things. > > How about a fixup in the platform code to add the property then? Dunno, do you have an example? -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog