From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751526AbdFHSSa (ORCPT ); Thu, 8 Jun 2017 14:18:30 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33662 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751393AbdFHSS2 (ORCPT ); Thu, 8 Jun 2017 14:18:28 -0400 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Andy Shevchenko Subject: Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure Date: Thu, 8 Jun 2017 20:18:24 +0200 User-Agent: KMail/1.13.7 (Linux/3.13.0-117-generic; KDE/4.14.2; x86_64; ; ) Cc: Joe Perches , Darren Hart , Andy Shevchenko , Andy Lutomirski , Platform Driver , "linux-kernel@vger.kernel.org" References: <1495885877-7906-1-git-send-email-pali.rohar@gmail.com> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1999385.6sYS1qN7Vr"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201706082018.24251@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart1999385.6sYS1qN7Vr Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Thursday 08 June 2017 19:44:39 Andy Shevchenko wrote: > On Thu, Jun 8, 2017 at 8:42 PM, Andy Shevchenko >=20 > wrote: > > On Thu, Jun 8, 2017 at 6:38 PM, Joe Perches wrote: > >> On Thu, 2017-06-08 at 08:16 -0700, Darren Hart wrote: > >>> On Sat, May 27, 2017 at 11:49:22PM +0300, Andy Shevchenko wrote: > >>> > On Sat, May 27, 2017 at 11:48 PM, Pali Roh=C3=A1r > >>> > wrote: > >>> > > On Saturday 27 May 2017 15:33:14 Andy Shevchenko wrote: > >> Perhaps > >>=20 > >> pr_info("\t%*pE\n", (int)sizeof(g->object_id), > >> g->object_id); > >=20 > > It will print some noisy characters as far as I understood the > > initial intention. >=20 > Ah, sorry, it will work, though sligtly differently. It will take > extra argument from the stack which we can avoid. I don't expect the > size of that growing. Pali? ObjectID is always 2 bytes. And it should be printable ASCII (probably=20 only [A-Za-z0-9_]) as it is used as ACPI method name. Size is not going to change. =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart1999385.6sYS1qN7Vr Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlk5lPAACgkQi/DJPQPkQ1L7dwCgvPVog/JilSOlsrraqYiRwTpF YX0AoJ44mqeo04mFsDvtEtjZdV1Il1qA =HLew -----END PGP SIGNATURE----- --nextPart1999385.6sYS1qN7Vr--