* [PATCH] wireless: wlcore: spi: remove unnecessary variable
@ 2017-06-09 3:24 Gustavo A. R. Silva
2017-06-09 8:12 ` Kalle Valo
2017-06-13 7:07 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2017-06-09 3:24 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-wireless, netdev, linux-kernel, Gustavo A. R. Silva
Remove unnecessary variable and refactor the code.
Addresses-Coverity-ID: 1365000
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/net/wireless/ti/wlcore/spi.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/ti/wlcore/spi.c b/drivers/net/wireless/ti/wlcore/spi.c
index fa3547e..d2d899a 100644
--- a/drivers/net/wireless/ti/wlcore/spi.c
+++ b/drivers/net/wireless/ti/wlcore/spi.c
@@ -366,17 +366,14 @@ static int __wl12xx_spi_raw_write(struct device *child, int addr,
static int __must_check wl12xx_spi_raw_write(struct device *child, int addr,
void *buf, size_t len, bool fixed)
{
- int ret;
-
/* The ELP wakeup write may fail the first time due to internal
* hardware latency. It is safer to send the wakeup command twice to
* avoid unexpected failures.
*/
if (addr == HW_ACCESS_ELP_CTRL_REG)
- ret = __wl12xx_spi_raw_write(child, addr, buf, len, fixed);
- ret = __wl12xx_spi_raw_write(child, addr, buf, len, fixed);
+ __wl12xx_spi_raw_write(child, addr, buf, len, fixed);
- return ret;
+ return __wl12xx_spi_raw_write(child, addr, buf, len, fixed);
}
/**
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] wireless: wlcore: spi: remove unnecessary variable
2017-06-09 3:24 [PATCH] wireless: wlcore: spi: remove unnecessary variable Gustavo A. R. Silva
@ 2017-06-09 8:12 ` Kalle Valo
2017-06-13 7:07 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2017-06-09 8:12 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: linux-wireless, netdev, linux-kernel
"Gustavo A. R. Silva" <garsilva@embeddedor.com> writes:
> Remove unnecessary variable and refactor the code.
>
> Addresses-Coverity-ID: 1365000
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
I'll remove "wireless:" from the prefix.
--
Kalle Valo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: wlcore: spi: remove unnecessary variable
2017-06-09 3:24 [PATCH] wireless: wlcore: spi: remove unnecessary variable Gustavo A. R. Silva
2017-06-09 8:12 ` Kalle Valo
@ 2017-06-13 7:07 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2017-06-13 7:07 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: linux-wireless, netdev, linux-kernel, Gustavo A. R. Silva
"Gustavo A. R. Silva" <garsilva@embeddedor.com> wrote:
> Remove unnecessary variable and refactor the code.
>
> Addresses-Coverity-ID: 1365000
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Patch applied to wireless-drivers-next.git, thanks.
c48c281e7236 wlcore: spi: remove unnecessary variable
--
https://patchwork.kernel.org/patch/9777073/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-13 7:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-09 3:24 [PATCH] wireless: wlcore: spi: remove unnecessary variable Gustavo A. R. Silva
2017-06-09 8:12 ` Kalle Valo
2017-06-13 7:07 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).