From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751628AbdFII3I (ORCPT ); Fri, 9 Jun 2017 04:29:08 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:38046 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751535AbdFII3F (ORCPT ); Fri, 9 Jun 2017 04:29:05 -0400 Date: Fri, 9 Jun 2017 10:29:02 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Darren Hart Cc: Andy Shevchenko , Andy Shevchenko , Andy Lutomirski , Platform Driver , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure Message-ID: <20170609082902.GR4690@pali> References: <1495885877-7906-1-git-send-email-pali.rohar@gmail.com> <201705271517.30111@pali> <201705272248.13257@pali> <20170608151618.GE32509@fury> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170608151618.GE32509@fury> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 08 June 2017 08:16:18 Darren Hart wrote: > On Sat, May 27, 2017 at 11:49:22PM +0300, Andy Shevchenko wrote: > > On Sat, May 27, 2017 at 11:48 PM, Pali Rohár wrote: > > > On Saturday 27 May 2017 15:33:14 Andy Shevchenko wrote: > > >> On Sat, May 27, 2017 at 4:17 PM, Pali Rohár > > >> wrote: > > > > >> Okay, got it. But on your opinion does it make sense to do > > >> > > >> pr_info("\tobject_id: %2pE\n", g->object_id); > > >> > > >> instead? > > >> > > >> For ASCII it will go as is previously, otherwise escaping would be > > >> done. > > > > > > Both is OK for me. Do you want to send a new patch with %2pE? > > > > To me it looks slightly cleaner. > > I don't want to let this one fall through the cracks. Pali, is a new one coming? So.. which modifier to use? Andy already proposed two alternatives and basically I'm fine all 3 which are in this thread. -- Pali Rohár pali.rohar@gmail.com