* Re: [PATCH] KVM: ARM64: fix phy counter access failure in guest.
2017-06-09 16:22 [PATCH] KVM: ARM64: fix phy counter access failure in guest Hu Huajun
@ 2017-06-09 8:41 ` Christoffer Dall
0 siblings, 0 replies; 2+ messages in thread
From: Christoffer Dall @ 2017-06-09 8:41 UTC (permalink / raw)
To: Hu Huajun
Cc: christoffer.dall, marc.zyngier, rkrcmar, linux-arm-kernel, kvmarm,
kvm, linux-kernel, songwenjun, gengdongjiu
Hi,
On Sat, Jun 10, 2017 at 12:22:20AM +0800, Hu Huajun wrote:
> When reading the cntpct_el0 in guest with VHE (Virtual Host Extension)
> enabled in host, the "Unsupported guest sys_reg access" error reported.
> The reason is cnthctl_el2.EL1PCTEN is not enabled, which is expected
> to be done in kvm_timer_init_vhe(). The problem is kvm_timer_init_vhe
> is called by cpu_init_hyp_mode, and which is called when VHE is disabled.
> This patch calls kvm_timer_init_vhe() to enable cnthctl_el2.EL1PCTEN
> in cpu_hyp_reinit().
>
> Signed-off-by: Hu Huajun <huhuajun@huawei.com>
> ---
> virt/kvm/arm/arm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c
> index 3417e18..b703741 100644
> --- a/virt/kvm/arm/arm.c
> +++ b/virt/kvm/arm/arm.c
> @@ -1137,6 +1137,7 @@ static void cpu_hyp_reinit(void)
> * event was cancelled before the CPU was reset.
> */
> __cpu_init_stage2();
> + kvm_timer_init_vhe();
> } else {
> cpu_init_hyp_mode(NULL);
> }
> --
> 2.10.1
>
Could you rework this patch to remove the incorrect call to
kvm_timer_init_vhe() from cpu_init_hyp_mode() as well?
Thanks,
-Christoffer
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] KVM: ARM64: fix phy counter access failure in guest.
@ 2017-06-09 16:22 Hu Huajun
2017-06-09 8:41 ` Christoffer Dall
0 siblings, 1 reply; 2+ messages in thread
From: Hu Huajun @ 2017-06-09 16:22 UTC (permalink / raw)
To: christoffer.dall, marc.zyngier, rkrcmar
Cc: linux-arm-kernel, kvmarm, kvm, linux-kernel, songwenjun,
gengdongjiu, huhuajun
When reading the cntpct_el0 in guest with VHE (Virtual Host Extension)
enabled in host, the "Unsupported guest sys_reg access" error reported.
The reason is cnthctl_el2.EL1PCTEN is not enabled, which is expected
to be done in kvm_timer_init_vhe(). The problem is kvm_timer_init_vhe
is called by cpu_init_hyp_mode, and which is called when VHE is disabled.
This patch calls kvm_timer_init_vhe() to enable cnthctl_el2.EL1PCTEN
in cpu_hyp_reinit().
Signed-off-by: Hu Huajun <huhuajun@huawei.com>
---
virt/kvm/arm/arm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c
index 3417e18..b703741 100644
--- a/virt/kvm/arm/arm.c
+++ b/virt/kvm/arm/arm.c
@@ -1137,6 +1137,7 @@ static void cpu_hyp_reinit(void)
* event was cancelled before the CPU was reset.
*/
__cpu_init_stage2();
+ kvm_timer_init_vhe();
} else {
cpu_init_hyp_mode(NULL);
}
--
2.10.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-09 8:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-09 16:22 [PATCH] KVM: ARM64: fix phy counter access failure in guest Hu Huajun
2017-06-09 8:41 ` Christoffer Dall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).