From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next v2 1/7] net: dsa: mv888e6xxx: do not use netdev printing
Date: Fri, 9 Jun 2017 15:16:10 +0200 [thread overview]
Message-ID: <20170609131610.GA20756@lunn.ch> (raw)
In-Reply-To: <20170608223414.594-2-vivien.didelot@savoirfairelinux.com>
On Thu, Jun 08, 2017 at 06:34:08PM -0400, Vivien Didelot wrote:
> The mv888e6xxx driver accesses a port's netdev mostly for printing.
>
> This is bad for 2 reasons: DSA and CPU ports do not have a netdev
> pointer; it doesn't give us a correct picture of why a DSA driver might
> need to access a port's netdev.
>
> Instead simply use dev_* printing functions with chip->dev (or ds->dev
> depending on the scope, both guaranteed to exist), with a p%d prefix for
> the target port.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2017-06-09 13:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 22:34 [PATCH net-next v2 0/7] net: dsa: mv88e6xxx: ops cosmetics Vivien Didelot
2017-06-08 22:34 ` [PATCH net-next v2 1/7] net: dsa: mv888e6xxx: do not use netdev printing Vivien Didelot
2017-06-09 13:16 ` Andrew Lunn [this message]
2017-06-08 22:34 ` [PATCH net-next v2 2/7] net: dsa: mv88e6xxx: add egress mode enumeration Vivien Didelot
2017-06-08 22:34 ` [PATCH net-next v2 3/7] net: dsa: mv88e6xxx: use bridge state values Vivien Didelot
2017-06-09 13:17 ` Andrew Lunn
2017-06-08 22:34 ` [PATCH net-next v2 4/7] net: dsa: mv88e6xxx: do not prefix ops with g1 Vivien Didelot
2017-06-08 22:34 ` [PATCH net-next v2 5/7] net: dsa: mv88e6xxx: rework pause limit operation Vivien Didelot
2017-06-08 22:34 ` [PATCH net-next v2 6/7] net: dsa: mv88e6xxx: rework jumbo size operation Vivien Didelot
2017-06-08 22:34 ` [PATCH net-next v2 7/7] net: dsa: mv88e6xxx: prefix PHY macros Vivien Didelot
2017-06-09 16:11 ` [PATCH net-next v2 0/7] net: dsa: mv88e6xxx: ops cosmetics David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609131610.GA20756@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox