* [PATCH][-next] sched/deadline: make new function grub_reclaim static
@ 2017-06-09 11:08 Colin King
2017-06-09 11:25 ` Luca Abeni
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-06-09 11:08 UTC (permalink / raw)
To: Luca Abeni, Ingo Molnar, Peter Zijlstra, linux-kernel; +Cc: kernel-janitors
From: Colin Ian King <colin.king@canonical.com>
Make function grub_reclaim static to clean up the following sparse
warning:
"warning: symbol 'grub_reclaim' was not declared. Should it be static?"
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
kernel/sched/deadline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index e12f85975857..2ddb4e6d820f 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -1052,7 +1052,7 @@ extern bool sched_rt_bandwidth_account(struct rt_rq *rt_rq);
* should be larger than 2^(64 - 20 - 8), which is more than 64 seconds.
* So, overflow is not an issue here.
*/
-u64 grub_reclaim(u64 delta, struct rq *rq, struct sched_dl_entity *dl_se)
+static u64 grub_reclaim(u64 delta, struct rq *rq, struct sched_dl_entity *dl_se)
{
u64 u_inact = rq->dl.this_bw - rq->dl.running_bw; /* Utot - Uact */
u64 u_act;
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][-next] sched/deadline: make new function grub_reclaim static
2017-06-09 11:08 [PATCH][-next] sched/deadline: make new function grub_reclaim static Colin King
@ 2017-06-09 11:25 ` Luca Abeni
0 siblings, 0 replies; 2+ messages in thread
From: Luca Abeni @ 2017-06-09 11:25 UTC (permalink / raw)
To: Colin King; +Cc: Ingo Molnar, Peter Zijlstra, linux-kernel, kernel-janitors
On Fri, 9 Jun 2017 12:08:51 +0100
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Make function grub_reclaim static to clean up the following sparse
> warning:
>
> "warning: symbol 'grub_reclaim' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> kernel/sched/deadline.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index e12f85975857..2ddb4e6d820f 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -1052,7 +1052,7 @@ extern bool sched_rt_bandwidth_account(struct rt_rq *rt_rq);
> * should be larger than 2^(64 - 20 - 8), which is more than 64 seconds.
> * So, overflow is not an issue here.
> */
> -u64 grub_reclaim(u64 delta, struct rq *rq, struct sched_dl_entity *dl_se)
> +static u64 grub_reclaim(u64 delta, struct rq *rq, struct sched_dl_entity *dl_se)
> {
> u64 u_inact = rq->dl.this_bw - rq->dl.running_bw; /* Utot - Uact */
> u64 u_act;
Looks good; thanks for fixing this (and sorry for introducing the
warning).
Acked-by: Luca Abeni <luca.abeni@santannapisa.it>
Luca
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-09 11:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-09 11:08 [PATCH][-next] sched/deadline: make new function grub_reclaim static Colin King
2017-06-09 11:25 ` Luca Abeni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox