From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752015AbdFLIJV (ORCPT ); Mon, 12 Jun 2017 04:09:21 -0400 Received: from muru.com ([72.249.23.125]:51392 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750730AbdFLIJU (ORCPT ); Mon, 12 Jun 2017 04:09:20 -0400 Date: Mon, 12 Jun 2017 01:09:16 -0700 From: Tony Lindgren To: Kishon Vijay Abraham I Cc: Sebastian Reichel , Arnd Bergmann , Rob Herring , linux-kernel@vger.kernel.org Subject: Re: [PATCH] phy: cpcap-usb: add MUSB dependency Message-ID: <20170612080916.GV3730@atomide.com> References: <20170609101655.2730560-1-arnd@arndb.de> <20170609114714.ysbbd4y4zqxt6tzx@earth> <7ebc90ce-3b0e-528b-3138-127a802637ea@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7ebc90ce-3b0e-528b-3138-127a802637ea@ti.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Kishon Vijay Abraham I [170609 05:04]: > > > On Friday 09 June 2017 05:17 PM, Sebastian Reichel wrote: > > Hi, > > > > On Fri, Jun 09, 2017 at 12:16:40PM +0200, Arnd Bergmann wrote: > >> When MUSB is a loadable module, we get a link error for a built-in > >> CPCAP driver: > >> > >> drivers/phy/built-in.o: In function `cpcap_usb_phy_remove': > >> phy-cpcap-usb.c:(.text+0xed9): undefined reference to `musb_mailbox' > >> > >> This adds a Kconfig dependency to prevent this broken configuration, > >> enforcing that CPCAP can only be a module when MUSB is also a module. > >> > >> Fixes: 68a1f7c9d470 ("phy: cpcap-usb: Add CPCAP PMIC USB support") > >> Signed-off-by: Arnd Bergmann > > > > Reviewed-by: Sebastian Reichel > > merged, thanks! Yup thanks for fixing it. Regards, Tony