From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752516AbdFLLEA (ORCPT <rfc822;w@1wt.eu>);
        Mon, 12 Jun 2017 07:04:00 -0400
Received: from verein.lst.de ([213.95.11.211]:48787 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752010AbdFLLD7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 12 Jun 2017 07:03:59 -0400
Date: Mon, 12 Jun 2017 13:03:57 +0200
From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
        Christoph Hellwig <hch@lst.de>,
        Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
        Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] nvme: use uuid_t in nvme_ns
Message-ID: <20170612110357.GA22745@lst.de>
References: <20170612091240.18343-1-jthumshirn@suse.de> <CAHp75Ve+-+s3Fx4MnjXoXf3tjh_PkdnEKAKrXnmFWA_38_abnw@mail.gmail.com> <52228639-aedd-fdb9-0f02-448f8982758a@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <52228639-aedd-fdb9-0f02-448f8982758a@suse.de>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 12, 2017 at 12:04:18PM +0200, Johannes Thumshirn wrote:
> > So, this reveals two thins:
> > 1) shall we define NVME_NIDT_UUID_LEN to be UUID_LEN or substitute it
> > completely with the latter?
> 
> No, we have NVME_NIDT_UUID_LEN but also NVME_NIDT_NGUID_LEN and
> NVME_NIDT_EUI64_LEN.

Yeah, and I'd rather keep the defines for fields defined in the spec
in nvme.h

> I'm not sure the NVMe NGUID is the same as a GUID (a.k.a little endian
> UUID). Quoting from the spec:

It's not at all, the field just has a very unfortunate name in the
spec.