RE: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

Hunter, Adrian
2017-06-30T19:38:05Z

-----Original Message-----
From: Arnaldo Carvalho de Melo [mailto:acme@kernel.org]
Sent: Friday, June 30, 2017 5:54 PM
To: Hunter, Adrian <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>; linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events

> Em Fri, Jun 30, 2017 at 11:51:22AM +0300, Adrian Hunter escreveu:
> > On 06/30/2017 05:08 AM, Arnaldo Carvalho de Melo wrote:
> > > Em Thu, Jun 29, 2017 at 05:13:54PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Ok, passes all tests (gcc, clang where available) on:
>
> > > 41 ubuntu:16.10: Ok
> > > 42 ubuntu:17.04: Ok
>
> > > Can you provide new versions for the relevant patches?

> > I have sent new versions of the 2 patches affected.

> Thanks, a grafted those in my branch, will perform the usual build tests, then try it on a kaby lake machine.

> Have you thought about further "perf test" test cases to make sure this code stays working with all this infrastructure and details?

> Things like running synthetic workloads and getting a short sequence known to have these new packet types, checking if the hardware performing the tests is capable of generating such traces, etc?

The power events might not occur. Ptwrite and cbr might be possible. Perhaps simpler to just synthesize and then parse the events back to check them.