From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Evgeniy Polyakov <zbr@ioremap.net>,
Sebastian Reichel <sre@kernel.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/1] w1: Add subsystem kernel public interface
Date: Mon, 12 Jun 2017 16:29:32 +0200 [thread overview]
Message-ID: <20170612142932.GA31457@kroah.com> (raw)
In-Reply-To: <cdf6a90d-a3a8-4b40-3cf5-73ba4898ff11@ti.com>
On Mon, Jun 12, 2017 at 09:24:04AM -0500, Andrew F. Davis wrote:
> On 06/10/2017 07:51 AM, Greg Kroah-Hartman wrote:
> > On Mon, Jun 05, 2017 at 08:52:08AM -0500, Andrew F. Davis wrote:
> >> Like other subsystems we should be able to define slave devices outside
> >> of the w1 directory. To do this we move public facing interface
> >> definitions to include/linux/w1.h and rename the internal definition
> >> file to w1_internal.h.
> >>
> >> As w1_family.h and w1_int.h contained almost entirely public
> >> driver interface definitions we simply removed these files and
> >> moved the remaining definitions into w1_internal.h.
> >>
> >> With this we can now start to move slave devices out of w1/slaves and
> >> into the subsystem based on the function they implement, again like
> >> other drivers.
> >>
> >> Signed-off-by: Andrew F. Davis <afd@ti.com>
> >> Reviewed-by: Sebastian Reichel <sre@kernel.org>
> >> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
> >> ---
> >> MAINTAINERS | 1 +
> >> drivers/power/supply/ds2760_battery.c | 2 +-
> >> drivers/power/supply/ds2780_battery.c | 2 +-
> >> drivers/power/supply/ds2781_battery.c | 2 +-
> >> drivers/w1/masters/ds1wm.c | 3 +-
> >> drivers/w1/masters/ds2482.c | 3 +-
> >> drivers/w1/masters/ds2490.c | 3 +-
> >> drivers/w1/masters/matrox_w1.c | 3 +-
> >> drivers/w1/masters/mxc_w1.c | 3 +-
> >> drivers/w1/masters/omap_hdq.c | 3 +-
> >> drivers/w1/masters/w1-gpio.c | 3 +-
> >> drivers/w1/slaves/w1_bq27000.c | 6 +-
> >> drivers/w1/slaves/w1_ds2405.c | 5 +-
> >> drivers/w1/slaves/w1_ds2406.c | 6 +-
> >> drivers/w1/slaves/w1_ds2408.c | 6 +-
> >> drivers/w1/slaves/w1_ds2413.c | 6 +-
> >> drivers/w1/slaves/w1_ds2423.c | 6 +-
> >> drivers/w1/slaves/w1_ds2431.c | 6 +-
> >> drivers/w1/slaves/w1_ds2433.c | 6 +-
> >> drivers/w1/slaves/w1_ds2438.c | 5 +-
> >> drivers/w1/slaves/w1_ds2760.c | 7 ++-
> >> drivers/w1/slaves/w1_ds2780.c | 7 ++-
> >> drivers/w1/slaves/w1_ds2781.c | 7 ++-
> >> drivers/w1/slaves/w1_ds28e04.c | 6 +-
> >> drivers/w1/slaves/w1_smem.c | 7 ++-
> >> drivers/w1/slaves/w1_therm.c | 10 ++-
> >> drivers/w1/w1.c | 6 +-
> >> drivers/w1/w1_family.c | 3 +-
> >> drivers/w1/w1_family.h | 98 -----------------------------
> >> drivers/w1/w1_int.c | 3 +-
> >> drivers/w1/w1_int.h | 27 --------
> >> drivers/w1/w1_internal.h | 87 ++++++++++++++++++++++++++
> >> drivers/w1/w1_io.c | 2 +-
> >> drivers/w1/w1_netlink.c | 2 +-
> >> drivers/w1/w1_netlink.h | 2 +-
> >> {drivers/w1 => include/linux}/w1.h | 114 +++++++++++++++-------------------
> >> 36 files changed, 208 insertions(+), 260 deletions(-)
> >> delete mode 100644 drivers/w1/w1_family.h
> >> delete mode 100644 drivers/w1/w1_int.h
> >> create mode 100644 drivers/w1/w1_internal.h
> >> rename {drivers/w1 => include/linux}/w1.h (76%)
> >
> > You forgot to update Documentation/DocBook/w1.tmpl, and now the
> > documentation build breaks :(
> >
> > Can you please send me a patch to fix that up?
>
> It looks like in -next DocBook/w1.tmpl has been converted to
> driver-api/w1.rst, should I just fix up the .rst version, or would you
> also like a patch for your tree to keep it building for now?
Fixing up my tree would be best for now.
We can handle the merge issue if it happens afterward.
thanks,
greg k-h
next prev parent reply other threads:[~2017-06-12 14:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 13:52 [PATCH v3 0/1] Add public w1 driver interface Andrew F. Davis
2017-06-05 13:52 ` [PATCH v3 1/1] w1: Add subsystem kernel public interface Andrew F. Davis
[not found] ` <56941496682285@web32j.yandex.ru>
2017-06-08 12:19 ` Sebastian Reichel
2017-06-09 9:55 ` Greg Kroah-Hartman
2017-06-10 12:51 ` Greg Kroah-Hartman
2017-06-12 14:24 ` Andrew F. Davis
2017-06-12 14:29 ` Greg Kroah-Hartman [this message]
2017-06-12 14:42 ` [PATCH] DocBook: w1: Update W1 file locations and names in DocBook Andrew F. Davis
2017-06-12 21:23 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170612142932.GA31457@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=afd@ti.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sre@kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox