From: Olav Haugan <ohaugan@codeaurora.org>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: catalin.marinas@arm.com, will.deacon@arm.com,
robin.murphy@arm.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64/dma-mapping: Fix null-pointer check
Date: Mon, 12 Jun 2017 13:36:20 -0700 [thread overview]
Message-ID: <20170612203620.yrdb3pnrm6xt6nub@codeaurora.org> (raw)
In-Reply-To: <20170610220354.GY4902@n2100.armlinux.org.uk>
On 17-06-10 23:03:54, Russell King - ARM Linux wrote:
> On Sat, Jun 10, 2017 at 12:41:10PM -0700, Olav Haugan wrote:
> > @@ -149,6 +140,11 @@ static void *__dma_alloc(struct device *dev, size_t size,
> > bool coherent = is_device_dma_coherent(dev);
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> This re-introduces an instance that you say you're getting rid of...
>
The ARM64 version of is_device_dma_coherent() checks for !dev
already...But anyway I will completely remove the !dev checks in the
alloc/free functions since as Catalin pointed out it is coverted
elsewhere.
--
.Olav
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-06-12 20:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-10 19:41 [PATCH] arm64/dma-mapping: Fix null-pointer check Olav Haugan
2017-06-10 22:03 ` Russell King - ARM Linux
2017-06-12 20:36 ` Olav Haugan [this message]
2017-06-12 12:29 ` Catalin Marinas
2017-06-12 20:33 ` Olav Haugan
2017-06-12 20:50 ` Olav Haugan
2017-06-13 9:03 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170612203620.yrdb3pnrm6xt6nub@codeaurora.org \
--to=ohaugan@codeaurora.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=robin.murphy@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox