From: Guenter Roeck <linux@roeck-us.net>
To: Jaya Durga <jayad@cdac.in>
Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
florian.c.schilhabel@googlemail.com,
driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [10/10] Staging: rtl8712: ieee80211: fixed coding style issue
Date: Mon, 12 Jun 2017 13:57:11 -0700 [thread overview]
Message-ID: <20170612205711.GA28052@roeck-us.net> (raw)
In-Reply-To: <1497206646-20998-1-git-send-email-jayad@cdac.in>
On Mon, Jun 12, 2017 at 12:14:06AM +0530, Jaya Durga wrote:
> Fixed WARNING: line over 80 characters
>
> Signed-off-by: Jaya Durga <jayad@cdac.in>
> ---
> drivers/staging/rtl8712/ieee80211.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --
> 1.9.1
>
> diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c
> index 6e673c1..97ef063 100644
> --- a/drivers/staging/rtl8712/ieee80211.c
> +++ b/drivers/staging/rtl8712/ieee80211.c
> @@ -174,8 +174,8 @@ int r8712_generate_ie(struct registry_priv *pregistrypriv)
> sz += 8;
> ie += sz;
> /*beacon interval : 2bytes*/
> - *(__le16 *)ie = cpu_to_le16(
> - (u16)pdev_network->configuration.beacon_period);
> + struct NDIS_802_11_CONFIGURATION *cfg = &pdev_network->configuration;
> + *(__le16 *)ie = cpu_to_le16(cfg->beacon_period);
Do you really think that the resulting
drivers/staging/rtl8712/ieee80211.c:177:2: warning:
ISO C90 forbids mixed declarations and code
is better ?
Guenter
> sz += 2;
> ie += 2;
> /*capability info*/
prev parent reply other threads:[~2017-06-12 20:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-11 18:44 [PATCH 10/10] Staging: rtl8712: ieee80211: fixed coding style issue Jaya Durga
2017-06-12 12:12 ` Dan Carpenter
[not found] ` <1515429128.1447.1497331078332.JavaMail.open-xchange@webmail.cdac.in>
2017-06-13 5:55 ` Greg KH
2017-06-13 6:52 ` R Jayadurga
2017-06-12 20:57 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170612205711.GA28052@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jayad@cdac.in \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox