From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751927AbdFMHf0 (ORCPT ); Tue, 13 Jun 2017 03:35:26 -0400 Received: from muru.com ([72.249.23.125]:51538 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750818AbdFMHfY (ORCPT ); Tue, 13 Jun 2017 03:35:24 -0400 Date: Tue, 13 Jun 2017 00:35:20 -0700 From: Tony Lindgren To: Enric Balletbo i Serra Cc: linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Rob Herring , Mark Rutland , Russell King , Lee Jones , Sebastian Reichel , grygorii.strashko@ti.com, javier@dowhile0.org Subject: Re: [PATCH 2/4] ARM: dts: tps65217: Add power button interrupt to the common tps65217.dtsi file Message-ID: <20170613073519.GA3730@atomide.com> References: <20170612212412.22719-1-enric.balletbo@collabora.com> <20170612212412.22719-2-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170612212412.22719-2-enric.balletbo@collabora.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Enric Balletbo i Serra [170612 14:28]: > The interrupt for power button is static data that comes from the > datasheet, there is no reason to need to define this value on every > board so seams reasonable put this information into the common tps65217 > file. I think there's a problem with these patches where we no longer know if the interrupts are wired up on a board. For example, if the USB PHY VBUS interrupt is not connected, the phy driver needs poll the cable state. And on some PMICs some pins can be muxed to GPIO mode, don't remember if that can be done with tps65217. Regards, Tony