From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: <lgirdwood@gmail.com>, <linux-kernel@vger.kernel.org>,
<patches@opensource.cirrus.com>
Subject: Re: [PATCH] regulator: core: Prioritise consumer mappings over regulator name
Date: Tue, 13 Jun 2017 09:07:31 +0100 [thread overview]
Message-ID: <20170613080731.GB28618@localhost.localdomain> (raw)
In-Reply-To: <20170612163856.vctl42rg674r72bj@sirena.org.uk>
On Mon, Jun 12, 2017 at 05:38:56PM +0100, Mark Brown wrote:
> On Mon, Jun 12, 2017 at 04:17:52PM +0100, Charles Keepax wrote:
>
> > r = regulator_lookup_by_name(supply);
> > - if (r)
> > - return r;
>
> Why have you left the lookup here?
Yeah was thinking that could maybe use a comment, if we don't
find a match in the following loop over the supply map then we
will exit with the regulator found here. So we can still use the
regulator name for lookup just we default to the supply map.
Thanks,
Charles
next prev parent reply other threads:[~2017-06-13 8:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 15:17 [PATCH] regulator: core: Prioritise consumer mappings over regulator name Charles Keepax
2017-06-12 16:38 ` Mark Brown
2017-06-13 8:07 ` Charles Keepax [this message]
2017-06-13 10:15 ` Mark Brown
2017-06-13 13:16 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170613080731.GB28618@localhost.localdomain \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox