From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752434AbdFMJsy (ORCPT ); Tue, 13 Jun 2017 05:48:54 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:55166 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751834AbdFMJsv (ORCPT ); Tue, 13 Jun 2017 05:48:51 -0400 Date: Tue, 13 Jun 2017 11:48:41 +0200 From: Greg Kroah-Hartman To: Alan Cox Cc: Johan Hovold , Jiri Slaby , Tony Luck , Fenghua Yu , Samuel Ortiz , "David S. Miller" , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code Message-ID: <20170613094841.GA31846@kroah.com> References: <20170606105441.689-1-johan@kernel.org> <20170606105441.689-9-johan@kernel.org> <20170606122704.3e328125@lxorguk.ukuu.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170606122704.3e328125@lxorguk.ukuu.org.uk> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 06, 2017 at 12:27:04PM +0100, Alan Cox wrote: > On Tue, 6 Jun 2017 12:54:40 +0200 > Johan Hovold wrote: > > > Remove three ifdefed and broken implementations of TIOCSSERIAL and > > TIOCGICOUNT, and parity handling in set_termios which had suffered > > severe bit rot. > > I would be amazed if the IRDA code still works. It's not been tested > properly for years and it never followed the tty rules properly in the > first place - so this looks good, although moving IRDA into staging > and /dev/null would IMHO be far better. > > IRDA is dead, and IR remotes are handled via completely different code. I agree, and we should move it into staging and out of the tree, I'll send netdev some patches for that... thanks, greg k-h