From: Greg KH <gregkh@linuxfoundation.org>
To: Fabian Wolff <fabian.wolff@fau.de>
Cc: horvatmate@gmail.com, hdegoede@redhat.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
linux-kernel@i4.cs.fau.de
Subject: Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around binary operators
Date: Tue, 13 Jun 2017 15:11:49 +0200 [thread overview]
Message-ID: <20170613131149.GA23757@kroah.com> (raw)
In-Reply-To: <20170613125843.GE14290@kroah.com>
On Tue, Jun 13, 2017 at 02:58:43PM +0200, Greg KH wrote:
> On Mon, Jun 12, 2017 at 12:46:10PM +0200, Fabian Wolff wrote:
> > This patch adds spaces around the binary operators '-' and '+', which
> > is the preferred style, and reformats a pointer argument declaration
> > to fix a false positive "spaces preferred around that '*'" message
> > reported by checkpatch.pl.
> >
> > Signed-off-by: Fabian Wolff <fabian.wolff@fau.de>
> > Signed-off-by: Mate Horvath <horvatmate@gmail.com>
> > ---
> > drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/os_dep/wifi_regd.c b/drivers/staging/rtl8723bs/os_dep/wifi_regd.c
> > index 9c61125..803eab0 100644
> > --- a/drivers/staging/rtl8723bs/os_dep/wifi_regd.c
> > +++ b/drivers/staging/rtl8723bs/os_dep/wifi_regd.c
> > @@ -20,7 +20,7 @@
> >
> > /* 2G chan 01 - chan 11 */
> > #define RTW_2GHZ_CH01_11 \
> > - REG_RULE(2412-10, 2462+10, 40, 0, 20, 0)
> > + REG_RULE(2412 - 10, 2462 + 10, 40, 0, 20, 0)
> >
> > /*
> > *We enable active scan on these a case
> > @@ -29,12 +29,12 @@
> >
> > /* 2G chan 12 - chan 13, PASSIV SCAN */
> > #define RTW_2GHZ_CH12_13 \
> > - REG_RULE(2467-10, 2472+10, 40, 0, 20, \
> > + REG_RULE(2467 - 10, 2472 + 10, 40, 0, 20, \
> > NL80211_RRF_PASSIVE_SCAN)
> >
> > /* 2G chan 14, PASSIVS SCAN, NO OFDM (B only) */
> > #define RTW_2GHZ_CH14 \
> > - REG_RULE(2484-10, 2484+10, 40, 0, 20, \
> > + REG_RULE(2484 - 10, 2484 + 10, 40, 0, 20, \
> > NL80211_RRF_PASSIVE_SCAN | NL80211_RRF_NO_OFDM)
> >
> > static const struct ieee80211_regdomain rtw_regdom_rd = {
> > @@ -116,8 +116,8 @@ static int _rtw_reg_notifier_apply(struct wiphy *wiphy,
> > }
> >
> > static const struct ieee80211_regdomain *_rtw_regdomain_select(struct
> > - rtw_regulatory
> > - *reg)
> > + rtw_regulatory *
> > + reg)
>
> Why make this last change? It's not an arithmatic one :(
And can you refresh this series and resend the remaining ones? They all
didn't apply :(
next prev parent reply other threads:[~2017-06-13 13:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 10:46 [PATCH 0/7] staging: rtl8723bs: wifi_regd.c: fix checkpatch errors and warnings Fabian Wolff
2017-06-12 10:46 ` [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around binary operators Fabian Wolff
2017-06-13 12:58 ` Greg KH
2017-06-13 13:11 ` Greg KH [this message]
2017-06-13 21:01 ` [PATCH v2 0/5] staging: rtl8723bs: wifi_regd.c: fix checkpatch errors and warnings Fabian Wolff
2017-06-13 21:01 ` [PATCH v2 1/5] staging: rtl8723bs: wifi_regd.c: put spaces around binary operators Fabian Wolff
2017-06-13 21:01 ` [PATCH v2 2/5] staging: rtl8723bs: wifi_regd.c: fix comment formatting Fabian Wolff
2017-06-13 21:01 ` [PATCH v2 3/5] staging: rtl8723bs: wifi_regd.c: remove superfluous spaces from pointer arguments Fabian Wolff
2017-06-13 21:01 ` [PATCH v2 4/5] staging: rtl8723bs: wifi_regd.c: adjust alignment to match open parenthesis Fabian Wolff
2017-06-13 21:01 ` [PATCH v2 5/5] staging: rtl8723bs: wifi_regd.c: insert blank line after declarations Fabian Wolff
2017-06-13 13:36 ` [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around binary operators Ian W MORRISON
2017-06-13 14:36 ` Dan Carpenter
2017-06-14 11:49 ` Ian W MORRISON
2017-06-14 12:19 ` Dan Carpenter
2017-06-14 13:25 ` Joe Perches
2017-06-12 10:46 ` [PATCH 2/7] staging: rtl8723bs: wifi_regd.c: fix checkpatch.pl warning 'Statements should start on a tabstop' Fabian Wolff
2017-06-12 10:46 ` [PATCH 3/7] staging: rtl8723bs: wifi_regd.c: fix comment formatting Fabian Wolff
2017-06-12 10:46 ` [PATCH 4/7] staging: rtl8723bs: wifi_regd.c: remove superfluous braces Fabian Wolff
2017-06-12 10:46 ` [PATCH 5/7] staging: rtl8723bs: wifi_regd.c: remove superfluous spaces from pointer arguments Fabian Wolff
2017-06-12 10:46 ` [PATCH 6/7] staging: rtl8723bs: wifi_regd.c: adjust alignment to match open parenthesis Fabian Wolff
2017-06-12 10:46 ` [PATCH 7/7] staging: rtl8723bs: wifi_regd.c: insert blank line after declarations Fabian Wolff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170613131149.GA23757@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=fabian.wolff@fau.de \
--cc=hdegoede@redhat.com \
--cc=horvatmate@gmail.com \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox