From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753500AbdFMPUT (ORCPT ); Tue, 13 Jun 2017 11:20:19 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:33989 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753175AbdFMPUS (ORCPT ); Tue, 13 Jun 2017 11:20:18 -0400 Date: Tue, 13 Jun 2017 17:20:14 +0200 From: Ingo Molnar To: Juergen Gross Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, boris.ostrovsky@oracle.com, hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, tony.luck@intel.com, bp@alien8.de Subject: Re: [PATCH v2] xen/mce: don't issue error message for failed /dev/mcelog registration Message-ID: <20170613152014.tax42aevmsfdopxa@gmail.com> References: <20170613134507.16983-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170613134507.16983-1-jgross@suse.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Juergen Gross wrote: > When running under Xen as dom0 /dev/mcelog is being registered by Xen > instead of the normal mcelog driver. Avoid an error message being > issued by the mcelog driver in this case. Instead issue an informative > message that Xen has registered the device. > > Signed-off-by: Juergen Gross > --- > arch/x86/kernel/cpu/mcheck/dev-mcelog.c | 11 +++++++++-- > drivers/xen/mcelog.c | 2 ++ > 2 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/cpu/mcheck/dev-mcelog.c b/arch/x86/kernel/cpu/mcheck/dev-mcelog.c > index 9c632cb88546..4eb5f7d1d593 100644 > --- a/arch/x86/kernel/cpu/mcheck/dev-mcelog.c > +++ b/arch/x86/kernel/cpu/mcheck/dev-mcelog.c > @@ -388,9 +388,16 @@ static __init int dev_mcelog_init_device(void) > /* register character device /dev/mcelog */ > err = misc_register(&mce_chrdev_device); > if (err) { > - pr_err("Unable to init device /dev/mcelog (rc: %d)\n", err); > - return err; > + if (err == -EBUSY) > + /* Xen dom0 might have registered the device already. */ > + pr_info("Unable to init device /dev/mcelog, already registered"); > + else { > + pr_err("Unable to init device /dev/mcelog (rc: %d)\n", > + err); > + return err; > + } Please only use balanced curly braces in conditional statements. Thanks, Ingo