From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753602AbdFMQxA (ORCPT ); Tue, 13 Jun 2017 12:53:00 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:47039 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751989AbdFMQw5 (ORCPT ); Tue, 13 Jun 2017 12:52:57 -0400 Date: Tue, 13 Jun 2017 09:52:55 -0700 From: Darren Hart To: Andy Shevchenko Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Andy Shevchenko , Andy Lutomirski , Joe Perches , Platform Driver , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] platform/x86: wmi: Fix printing info about WDG structure Message-ID: <20170613165255.GJ27850@fury> References: <1495885877-7906-1-git-send-email-pali.rohar@gmail.com> <1497092231-505-1-git-send-email-pali.rohar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 10, 2017 at 02:22:50PM +0300, Andy Shevchenko wrote: > On Sat, Jun 10, 2017 at 1:57 PM, Pali Rohár wrote: > > object_id and notify_id are in one union structure and their meaning is > > defined by flags. Therefore do not print notify_id for non-event block and > > do not print object_id for event block. Remove also reserved member as it > > does not have any defined meaning or type yet. > > > > As object_id and notify_id union members overlaps and have different types, > > it caused that kernel print to dmesg binary data. This patch eliminates it. > > > > Signed-off-by: Pali Rohár > > Reviewed-by: Andy Shevchenko Thanks Pali, nice fix. Queued to testing. -- Darren Hart VMware Open Source Technology Center