From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753788AbdFMSye (ORCPT <rfc822;w@1wt.eu>);
        Tue, 13 Jun 2017 14:54:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45248 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753742AbdFMSyd (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 13 Jun 2017 14:54:33 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8A2B219D229
Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jolsa@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8A2B219D229
Date: Tue, 13 Jun 2017 20:54:29 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: David Carrillo-Cisneros <davidcc@google.com>
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>, Simon Que <sque@chromium.org>,
        Wang Nan <wangnan0@huawei.com>, Jiri Olsa <jolsa@kernel.org>,
        He Kuang <hekuang@huawei.com>, Masami Hiramatsu <mhiramat@kernel.org>,
        Stephane Eranian <eranian@google.com>, Paul Turner <pjt@google.com>
Subject: Re: [PATCH v4 09/16] perf header: don't pass struct
 perf_file_section to process_##_feat
Message-ID: <20170613185429.GB6092@krava>
References: <20170613042932.141842-1-davidcc@google.com>
 <20170613042932.141842-10-davidcc@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170613042932.141842-10-davidcc@google.com>
User-Agent: Mutt/1.8.0 (2017-02-23)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 13 Jun 2017 18:54:32 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 12, 2017 at 09:29:25PM -0700, David Carrillo-Cisneros wrote:

SNIP

>  	struct cpu_cache_level *caches;
>  	u32 cnt, i, version;
> @@ -2084,8 +2073,7 @@ static int process_cache(struct perf_file_section *section __maybe_unused,
>  struct feature_ops {
>  	int (*write)(struct feat_fd *ff, struct perf_evlist *evlist);
>  	void (*print)(struct feat_fd *ff, FILE *fp);
> -	int (*process)(struct perf_file_section *section,
> -		       struct feat_fd *ff, void *data);
> +	int (*process)(struct feat_fd *ff, void *data);
>  	const char *name;
>  	bool full_only;
>  };
> @@ -2616,9 +2604,11 @@ static int perf_file_section__process(struct perf_file_section *section,
>  				      struct perf_header *ph,
>  				      int feat, int fd, void *data)
>  {
> -	struct feat_fd ff = {
> +	struct feat_fd fdd = {

no need to rename to fdd

jirka