From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753846AbdFMSyo (ORCPT <rfc822;w@1wt.eu>);
        Tue, 13 Jun 2017 14:54:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56144 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753801AbdFMSym (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 13 Jun 2017 14:54:42 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 66BF07E9CB
Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jolsa@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 66BF07E9CB
Date: Tue, 13 Jun 2017 20:54:36 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: David Carrillo-Cisneros <davidcc@google.com>
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>, Simon Que <sque@chromium.org>,
        Wang Nan <wangnan0@huawei.com>, Jiri Olsa <jolsa@kernel.org>,
        He Kuang <hekuang@huawei.com>, Masami Hiramatsu <mhiramat@kernel.org>,
        Stephane Eranian <eranian@google.com>, Paul Turner <pjt@google.com>
Subject: Re: [PATCH v4 12/16] perf header: add a buffer to struct feat_fd
Message-ID: <20170613185436.GC6092@krava>
References: <20170613042932.141842-1-davidcc@google.com>
 <20170613042932.141842-13-davidcc@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170613042932.141842-13-davidcc@google.com>
User-Agent: Mutt/1.8.0 (2017-02-23)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 13 Jun 2017 18:54:42 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 12, 2017 at 09:29:28PM -0700, David Carrillo-Cisneros wrote:

SNIP

>  /* Return: 0 if succeded, -ERR if failed. */
>  int write_padded(struct feat_fd *ff, const void *bf,
>  		 size_t count, size_t count_aligned)
> @@ -125,13 +151,32 @@ static int do_write_string(struct feat_fd *ff, const char *str)
>  	return write_padded(ff, str, olen, len);
>  }
>  
> -static int __do_read(struct feat_fd *ff, void *addr, ssize_t size)
> +static int __do_read_fd(struct feat_fd *ff, void *addr, ssize_t size)
>  {
> -	ssize_t ret = readn(ff->fd, addr, size);
> +		ssize_t ret = readn(ff->fd, addr, size);
> +
> +		if (ret != size)
> +			return ret < 0 ? (int)ret : -1;
> +		return 0;

extra tab in indent

jirka