From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753880AbdFMSyv (ORCPT <rfc822;w@1wt.eu>);
        Tue, 13 Jun 2017 14:54:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45756 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753535AbdFMSyt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 13 Jun 2017 14:54:49 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 034D376FB
Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jolsa@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 034D376FB
Date: Tue, 13 Jun 2017 20:54:45 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: David Carrillo-Cisneros <davidcc@google.com>
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>, Simon Que <sque@chromium.org>,
        Wang Nan <wangnan0@huawei.com>, Jiri Olsa <jolsa@kernel.org>,
        He Kuang <hekuang@huawei.com>, Masami Hiramatsu <mhiramat@kernel.org>,
        Stephane Eranian <eranian@google.com>, Paul Turner <pjt@google.com>
Subject: Re: [PATCH v4 15/16] perf tools: add feature header record to
 pipe-mode
Message-ID: <20170613185445.GD6092@krava>
References: <20170613042932.141842-1-davidcc@google.com>
 <20170613042932.141842-16-davidcc@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170613042932.141842-16-davidcc@google.com>
User-Agent: Mutt/1.8.0 (2017-02-23)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 13 Jun 2017 18:54:49 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 12, 2017 at 09:29:31PM -0700, David Carrillo-Cisneros wrote:

SNIP

> +
> +	for_each_set_bit(feat, header->adds_features, HEADER_FEAT_BITS) {
> +		if (!feat_ops[feat].synthesize) {
> +			pr_debug("No record header feature for header :%d\n", feat);
> +			continue;
> +		}
> +
> +		ff.offset = sizeof(*fe);
> +
> +		ret = feat_ops[feat].write(&ff, evlist);
> +		if (ret || ff.offset <= (ssize_t)sizeof(*fe)) {
> +			pr_debug("Error writing feature\n");
> +			continue;
> +		}
> +
> +		/* ff.buf may have changed due to realloc in do_write() */
> +		fe = ff.buf;
> +		memset(fe, 0, sizeof(*fe));
> +
> +		fe->feat_id = feat;
> +		fe->header.type = PERF_RECORD_HEADER_FEATURE;
> +		fe->header.size = ff.offset;
> +
> +		ret = process(tool, ff.buf, NULL, NULL);
> +		if (ret)

leaking ff.buf

jirka

> +			return ret;
> +	}
> +	free(ff.buf);
> +	return 0;
> +}
> +