From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753985AbdFMSzh (ORCPT <rfc822;w@1wt.eu>);
        Tue, 13 Jun 2017 14:55:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43458 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753968AbdFMSzd (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 13 Jun 2017 14:55:33 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5420D61D3B
Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jolsa@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 5420D61D3B
Date: Tue, 13 Jun 2017 20:55:29 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: David Carrillo-Cisneros <davidcc@google.com>
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>, Simon Que <sque@chromium.org>,
        Wang Nan <wangnan0@huawei.com>, Jiri Olsa <jolsa@kernel.org>,
        He Kuang <hekuang@huawei.com>, Masami Hiramatsu <mhiramat@kernel.org>,
        Stephane Eranian <eranian@google.com>, Paul Turner <pjt@google.com>
Subject: Re: [PATCH v4 14/16] perf tool: add show_feature_header to perf_tool
Message-ID: <20170613185529.GG6092@krava>
References: <20170613042932.141842-1-davidcc@google.com>
 <20170613042932.141842-15-davidcc@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170613042932.141842-15-davidcc@google.com>
User-Agent: Mutt/1.8.0 (2017-02-23)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 13 Jun 2017 18:55:33 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 12, 2017 at 09:29:30PM -0700, David Carrillo-Cisneros wrote:
> Add show_feat_hdr to control level of printed information
> of feature headers.
> 
> Signed-off-by: David Carrillo-Cisneros <davidcc@google.com>
> ---
>  tools/perf/builtin-report.c | 11 ++++++++---
>  tools/perf/builtin-script.c |  3 +++
>  tools/perf/util/tool.h      |  7 +++++++
>  3 files changed, 18 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 22478ff2b706..7620d708c78b 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -985,9 +985,14 @@ int cmd_report(int argc, const char **argv)
>  		perf_hpp_list.need_collapse = true;
>  	}
>  
> -	/* Force tty output for header output and per-thread stat. */
> -	if (report.header || report.header_only || report.show_threads)
> -		use_browser = 0;
> +	if (report.header || report.header_only) {
> +		report.tool.show_feat_hdr = SHOW_FEAT_HEADER;
> +		/* Force tty output for header output and per-thread stat. */
> +		if (report.show_threads)
> +			use_browser = 0;
> +	}

this breaks show_threads option.. simple 'perf report -T' will not set use_browser

jirka