From: Tony Lindgren <tony@atomide.com>
To: Enric Balletbo Serra <eballetbo@gmail.com>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-pm@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
Lee Jones <lee.jones@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Javier Martinez Canillas <javier@dowhile0.org>
Subject: Re: [PATCH 2/4] ARM: dts: tps65217: Add power button interrupt to the common tps65217.dtsi file
Date: Tue, 13 Jun 2017 21:55:52 -0700 [thread overview]
Message-ID: <20170614045551.GB3730@atomide.com> (raw)
In-Reply-To: <CAFqH_50syu5aHBQtJkh-Dpz8Yc_6w0X853DO46T3ZAAJ10F-Pw@mail.gmail.com>
* Enric Balletbo Serra <eballetbo@gmail.com> [170613 02:12]:
> Hi Tony,
>
> 2017-06-13 9:35 GMT+02:00 Tony Lindgren <tony@atomide.com>:
> > * Enric Balletbo i Serra <enric.balletbo@collabora.com> [170612 14:28]:
> >> The interrupt for power button is static data that comes from the
> >> datasheet, there is no reason to need to define this value on every
> >> board so seams reasonable put this information into the common tps65217
> >> file.
> >
> > I think there's a problem with these patches where we no longer know
> > if the interrupts are wired up on a board. For example, if the USB PHY
> > VBUS interrupt is not connected, the phy driver needs poll the
> > cable state.
> >
>
> Hmm, the tps65217 doesn't have a USB PHY like others tps, so not sure
> how could affect this patch. Did you see this issue in any board that
> uses tps65217 or any am335x based board which commonly uses this pmic?
Oh sorry I misread your patch. I thought you're removing
the interrupts from dts, but you're just moving the dts entries
to the common dtsi file :) So seems just fine with me.
Regards,
Tony
next prev parent reply other threads:[~2017-06-14 4:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 21:24 [PATCH 1/4] ARM: dts: tps65217: Add charger interrupts to the common tps65217.dtsi file Enric Balletbo i Serra
2017-06-12 21:24 ` [PATCH 2/4] ARM: dts: tps65217: Add power button interrupt " Enric Balletbo i Serra
2017-06-13 7:35 ` Tony Lindgren
2017-06-13 9:08 ` Enric Balletbo Serra
2017-06-14 4:55 ` Tony Lindgren [this message]
2017-08-10 16:24 ` Tony Lindgren
2017-06-12 21:24 ` [PATCH 3/4] mfd: tps65217: remove duplicated interrupt resources Enric Balletbo i Serra
2017-06-12 22:41 ` Grygorii Strashko
2017-06-13 8:18 ` Enric Balletbo Serra
2017-06-13 23:05 ` Grygorii Strashko
2017-06-12 21:24 ` [PATCH 4/4] power: supply: tps65217: able to disable the charger block Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614045551.GB3730@atomide.com \
--to=tony@atomide.com \
--cc=devicetree@vger.kernel.org \
--cc=eballetbo@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=grygorii.strashko@ti.com \
--cc=javier@dowhile0.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox