* [PATCH] tty/serial: remove AVR32 specific access wrappers
@ 2017-06-13 20:25 Alexandre Belloni
2017-06-14 7:43 ` Richard Genoud
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Alexandre Belloni @ 2017-06-13 20:25 UTC (permalink / raw)
To: Richard Genoud, Greg Kroah-Hartman
Cc: Nicolas Ferre, linux-serial, linux-arm-kernel, linux-kernel,
Alexandre Belloni
Now that AVR32 is gone, the specific wrappers for that architecture are
unnecessary and will not be compiled anymore.
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
drivers/tty/serial/atmel_serial.c | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index 937d67f22fba..8bfc566df2da 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -228,21 +228,6 @@ static inline void atmel_uart_writel(struct uart_port *port, u32 reg, u32 value)
__raw_writel(value, port->membase + reg);
}
-#ifdef CONFIG_AVR32
-
-/* AVR32 cannot handle 8 or 16bit I/O accesses but only 32bit I/O accesses */
-static inline u8 atmel_uart_read_char(struct uart_port *port)
-{
- return __raw_readl(port->membase + ATMEL_US_RHR);
-}
-
-static inline void atmel_uart_write_char(struct uart_port *port, u8 value)
-{
- __raw_writel(value, port->membase + ATMEL_US_THR);
-}
-
-#else
-
static inline u8 atmel_uart_read_char(struct uart_port *port)
{
return __raw_readb(port->membase + ATMEL_US_RHR);
@@ -253,8 +238,6 @@ static inline void atmel_uart_write_char(struct uart_port *port, u8 value)
__raw_writeb(value, port->membase + ATMEL_US_THR);
}
-#endif
-
#ifdef CONFIG_SERIAL_ATMEL_PDC
static bool atmel_use_pdc_rx(struct uart_port *port)
{
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] tty/serial: remove AVR32 specific access wrappers
2017-06-13 20:25 [PATCH] tty/serial: remove AVR32 specific access wrappers Alexandre Belloni
@ 2017-06-14 7:43 ` Richard Genoud
2017-06-14 9:43 ` Andy Shevchenko
2017-06-14 10:49 ` Greg Kroah-Hartman
2 siblings, 0 replies; 8+ messages in thread
From: Richard Genoud @ 2017-06-14 7:43 UTC (permalink / raw)
To: Alexandre Belloni, Greg Kroah-Hartman
Cc: Nicolas Ferre, linux-serial, linux-arm-kernel, linux-kernel
On 13/06/2017 22:25, Alexandre Belloni wrote:
> Now that AVR32 is gone, the specific wrappers for that architecture are
> unnecessary and will not be compiled anymore.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Richard Genoud <richard.genoud@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tty/serial: remove AVR32 specific access wrappers
2017-06-13 20:25 [PATCH] tty/serial: remove AVR32 specific access wrappers Alexandre Belloni
2017-06-14 7:43 ` Richard Genoud
@ 2017-06-14 9:43 ` Andy Shevchenko
2017-06-14 13:27 ` Alexandre Belloni
2017-06-14 10:49 ` Greg Kroah-Hartman
2 siblings, 1 reply; 8+ messages in thread
From: Andy Shevchenko @ 2017-06-14 9:43 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Richard Genoud, Greg Kroah-Hartman, Nicolas Ferre,
linux-serial@vger.kernel.org, linux-arm Mailing List,
linux-kernel@vger.kernel.org
On Tue, Jun 13, 2017 at 11:25 PM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> Now that AVR32 is gone, the specific wrappers for that architecture are
> unnecessary and will not be compiled anymore.
>
Can you rebase this on top of tty-next?
I'm pretty sure this patch will gone.
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> drivers/tty/serial/atmel_serial.c | 17 -----------------
> 1 file changed, 17 deletions(-)
>
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index 937d67f22fba..8bfc566df2da 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -228,21 +228,6 @@ static inline void atmel_uart_writel(struct uart_port *port, u32 reg, u32 value)
> __raw_writel(value, port->membase + reg);
> }
>
> -#ifdef CONFIG_AVR32
> -
> -/* AVR32 cannot handle 8 or 16bit I/O accesses but only 32bit I/O accesses */
> -static inline u8 atmel_uart_read_char(struct uart_port *port)
> -{
> - return __raw_readl(port->membase + ATMEL_US_RHR);
> -}
> -
> -static inline void atmel_uart_write_char(struct uart_port *port, u8 value)
> -{
> - __raw_writel(value, port->membase + ATMEL_US_THR);
> -}
> -
> -#else
> -
> static inline u8 atmel_uart_read_char(struct uart_port *port)
> {
> return __raw_readb(port->membase + ATMEL_US_RHR);
> @@ -253,8 +238,6 @@ static inline void atmel_uart_write_char(struct uart_port *port, u8 value)
> __raw_writeb(value, port->membase + ATMEL_US_THR);
> }
>
> -#endif
> -
> #ifdef CONFIG_SERIAL_ATMEL_PDC
> static bool atmel_use_pdc_rx(struct uart_port *port)
> {
> --
> 2.11.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] tty/serial: remove AVR32 specific access wrappers
2017-06-14 9:43 ` Andy Shevchenko
@ 2017-06-14 13:27 ` Alexandre Belloni
2017-06-14 14:15 ` Andy Shevchenko
0 siblings, 1 reply; 8+ messages in thread
From: Alexandre Belloni @ 2017-06-14 13:27 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Richard Genoud, Greg Kroah-Hartman, Nicolas Ferre,
linux-serial@vger.kernel.org, linux-arm Mailing List,
linux-kernel@vger.kernel.org
On 14/06/2017 at 12:43:40 +0300, Andy Shevchenko wrote:
> On Tue, Jun 13, 2017 at 11:25 PM, Alexandre Belloni
> <alexandre.belloni@free-electrons.com> wrote:
> > Now that AVR32 is gone, the specific wrappers for that architecture are
> > unnecessary and will not be compiled anymore.
> >
>
> Can you rebase this on top of tty-next?
>
> I'm pretty sure this patch will gone.
>
So you avoided most of the bikeshedding by not copying any of the
maintainers, nice...
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tty/serial: remove AVR32 specific access wrappers
2017-06-14 13:27 ` Alexandre Belloni
@ 2017-06-14 14:15 ` Andy Shevchenko
2017-06-14 14:26 ` Alexandre Belloni
0 siblings, 1 reply; 8+ messages in thread
From: Andy Shevchenko @ 2017-06-14 14:15 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Richard Genoud, Greg Kroah-Hartman, Nicolas Ferre,
linux-serial@vger.kernel.org, linux-arm Mailing List,
linux-kernel@vger.kernel.org
On Wed, Jun 14, 2017 at 4:27 PM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> On 14/06/2017 at 12:43:40 +0300, Andy Shevchenko wrote:
>> On Tue, Jun 13, 2017 at 11:25 PM, Alexandre Belloni
>> <alexandre.belloni@free-electrons.com> wrote:
>> > Now that AVR32 is gone, the specific wrappers for that architecture are
>> > unnecessary and will not be compiled anymore.
>> >
>>
>> Can you rebase this on top of tty-next?
>>
>> I'm pretty sure this patch will gone.
>>
>
> So you avoided most of the bikeshedding by not copying any of the
> maintainers, nice...
Wait, what? I used get_maintainer.pl script and I took its output + Greg.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tty/serial: remove AVR32 specific access wrappers
2017-06-14 14:15 ` Andy Shevchenko
@ 2017-06-14 14:26 ` Alexandre Belloni
0 siblings, 0 replies; 8+ messages in thread
From: Alexandre Belloni @ 2017-06-14 14:26 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Richard Genoud, Greg Kroah-Hartman, Nicolas Ferre,
linux-serial@vger.kernel.org, linux-arm Mailing List,
linux-kernel@vger.kernel.org
On 14/06/2017 at 17:15:32 +0300, Andy Shevchenko wrote:
> On Wed, Jun 14, 2017 at 4:27 PM, Alexandre Belloni
> <alexandre.belloni@free-electrons.com> wrote:
> > On 14/06/2017 at 12:43:40 +0300, Andy Shevchenko wrote:
> >> On Tue, Jun 13, 2017 at 11:25 PM, Alexandre Belloni
> >> <alexandre.belloni@free-electrons.com> wrote:
> >> > Now that AVR32 is gone, the specific wrappers for that architecture are
> >> > unnecessary and will not be compiled anymore.
> >> >
> >>
> >> Can you rebase this on top of tty-next?
> >>
> >> I'm pretty sure this patch will gone.
> >>
> >
> > So you avoided most of the bikeshedding by not copying any of the
> > maintainers, nice...
>
> Wait, what? I used get_maintainer.pl script and I took its output + Greg.
>
Yeah, get_maintainer is not ideal but that's fine. Probably the lakml
should be added.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tty/serial: remove AVR32 specific access wrappers
2017-06-13 20:25 [PATCH] tty/serial: remove AVR32 specific access wrappers Alexandre Belloni
2017-06-14 7:43 ` Richard Genoud
2017-06-14 9:43 ` Andy Shevchenko
@ 2017-06-14 10:49 ` Greg Kroah-Hartman
2017-06-14 13:32 ` Alexandre Belloni
2 siblings, 1 reply; 8+ messages in thread
From: Greg Kroah-Hartman @ 2017-06-14 10:49 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Richard Genoud, Nicolas Ferre, linux-serial, linux-arm-kernel,
linux-kernel
On Tue, Jun 13, 2017 at 10:25:17PM +0200, Alexandre Belloni wrote:
> Now that AVR32 is gone, the specific wrappers for that architecture are
> unnecessary and will not be compiled anymore.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> drivers/tty/serial/atmel_serial.c | 17 -----------------
> 1 file changed, 17 deletions(-)
Does not apply to my tty-next tree at all :(
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tty/serial: remove AVR32 specific access wrappers
2017-06-14 10:49 ` Greg Kroah-Hartman
@ 2017-06-14 13:32 ` Alexandre Belloni
0 siblings, 0 replies; 8+ messages in thread
From: Alexandre Belloni @ 2017-06-14 13:32 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Richard Genoud, Nicolas Ferre, linux-serial, linux-arm-kernel,
linux-kernel
On 14/06/2017 at 12:49:29 +0200, Greg Kroah-Hartman wrote:
> On Tue, Jun 13, 2017 at 10:25:17PM +0200, Alexandre Belloni wrote:
> > Now that AVR32 is gone, the specific wrappers for that architecture are
> > unnecessary and will not be compiled anymore.
> >
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > ---
> > drivers/tty/serial/atmel_serial.c | 17 -----------------
> > 1 file changed, 17 deletions(-)
>
> Does not apply to my tty-next tree at all :(
>
That's fine, as Andy pointed out, he did the job.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-06-14 14:26 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-13 20:25 [PATCH] tty/serial: remove AVR32 specific access wrappers Alexandre Belloni
2017-06-14 7:43 ` Richard Genoud
2017-06-14 9:43 ` Andy Shevchenko
2017-06-14 13:27 ` Alexandre Belloni
2017-06-14 14:15 ` Andy Shevchenko
2017-06-14 14:26 ` Alexandre Belloni
2017-06-14 10:49 ` Greg Kroah-Hartman
2017-06-14 13:32 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox