From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752610AbdFNRus (ORCPT ); Wed, 14 Jun 2017 13:50:48 -0400 Received: from mail-it0-f48.google.com ([209.85.214.48]:36917 "EHLO mail-it0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751904AbdFNRur (ORCPT ); Wed, 14 Jun 2017 13:50:47 -0400 Date: Wed, 14 Jun 2017 11:50:42 -0600 From: Mathieu Poirier To: Suzuki K Poulose Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/12] coresight tmc: Expose DBA and AXICTL Message-ID: <20170614175042.GB22030@xps15> References: <1497278211-5001-1-git-send-email-suzuki.poulose@arm.com> <1497278211-5001-7-git-send-email-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1497278211-5001-7-git-send-email-suzuki.poulose@arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 12, 2017 at 03:36:45PM +0100, Suzuki K Poulose wrote: > Expose DBALO,DBAHI and AXICTL registers Why is this needed? I fear we are exposing internal kernel information. > > Cc: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-tmc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/hwtracing/coresight/coresight-tmc.c b/drivers/hwtracing/coresight/coresight-tmc.c > index 7025982..fd5a2e0 100644 > --- a/drivers/hwtracing/coresight/coresight-tmc.c > +++ b/drivers/hwtracing/coresight/coresight-tmc.c > @@ -228,9 +228,11 @@ coresight_tmc_simple_func(ffcr, TMC_FFCR); > coresight_tmc_simple_func(mode, TMC_MODE); > coresight_tmc_simple_func(pscr, TMC_PSCR); > coresight_tmc_simple_func(devid, CORESIGHT_DEVID); > +coresight_tmc_simple_func(axictl, TMC_AXICTL); > > coresight_simple_reg64(struct tmc_drvdata, rrp, TMC_RRP, TMC_RRPHI); > coresight_simple_reg64(struct tmc_drvdata, rwp, TMC_RWP, TMC_RWPHI); > +coresight_simple_reg64(struct tmc_drvdata, dba, TMC_DBALO, TMC_DBAHI); > > static struct attribute *coresight_tmc_mgmt_attrs[] = { > &dev_attr_rsz.attr, > @@ -244,6 +246,8 @@ static struct attribute *coresight_tmc_mgmt_attrs[] = { > &dev_attr_mode.attr, > &dev_attr_pscr.attr, > &dev_attr_devid.attr, > + &dev_attr_dba.attr, > + &dev_attr_axictl.attr, > NULL, > }; > > -- > 2.7.4 >