From: Matthias Kaehlcke <mka@chromium.org>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: pl330: Mark unused functions as __maybe_unused
Date: Wed, 14 Jun 2017 14:05:51 -0700 [thread overview]
Message-ID: <20170614210551.GN141096@google.com> (raw)
In-Reply-To: <20170614045831.GH13020@localhost>
El Wed, Jun 14, 2017 at 10:28:31AM +0530 Vinod Koul ha dit:
> On Fri, May 19, 2017 at 01:02:26PM -0700, Matthias Kaehlcke wrote:
> > Several functions are not used and probably kept around for completeness
> > or debugging. Adding the attribute fixes a bunch of warnings like this
> > when building with clang:
> >
> > drivers/dma/pl330.c:568:19: error: unused function '_emit_ADDH'
> > [-Werror,-Wunused-function]
>
> Well I dont see these being used, so why should we keep the dead code.
> Can you please remove these
Ok, I'll send a patch with the removal shortly
prev parent reply other threads:[~2017-06-14 21:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 20:02 [PATCH] dmaengine: pl330: Mark unused functions as __maybe_unused Matthias Kaehlcke
2017-06-14 4:58 ` Vinod Koul
2017-06-14 21:05 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614210551.GN141096@google.com \
--to=mka@chromium.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox