From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752439AbdFNVF4 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 14 Jun 2017 17:05:56 -0400
Received: from mail-pf0-f169.google.com ([209.85.192.169]:35609 "EHLO
        mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752097AbdFNVFy (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 14 Jun 2017 17:05:54 -0400
Date: Wed, 14 Jun 2017 14:05:51 -0700
From: Matthias Kaehlcke <mka@chromium.org>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
        Dan Williams <dan.j.williams@intel.com>, dmaengine@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: pl330: Mark unused functions as __maybe_unused
Message-ID: <20170614210551.GN141096@google.com>
References: <20170519200226.85420-1-mka@chromium.org>
 <20170614045831.GH13020@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20170614045831.GH13020@localhost>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

El Wed, Jun 14, 2017 at 10:28:31AM +0530 Vinod Koul ha dit:

> On Fri, May 19, 2017 at 01:02:26PM -0700, Matthias Kaehlcke wrote:
> > Several functions are not used and probably kept around for completeness
> > or debugging. Adding the attribute fixes a bunch of warnings like this
> > when building with clang:
> > 
> > drivers/dma/pl330.c:568:19: error: unused function '_emit_ADDH'
> >     [-Werror,-Wunused-function]
> 
> Well I dont see these being used, so why should we keep the dead code.
> Can you please remove these

Ok, I'll send a patch with the removal shortly