From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Peter Rosin <peda@lysator.liu.se>,
Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: linux-kernel@vger.kernel.org, Peter Rosin <peda@axentia.se>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: atmel-hlcdc: sama5d4 does not have overlay2
Date: Thu, 15 Jun 2017 11:37:48 +0200 [thread overview]
Message-ID: <20170615113748.1c98f898@bbrezillon> (raw)
In-Reply-To: <1497518653-2788-1-git-send-email-peda@lysator.liu.se>
On Thu, 15 Jun 2017 11:24:13 +0200
Peter Rosin <peda@lysator.liu.se> wrote:
> From: Peter Rosin <peda@axentia.se>
>
> Remove the layer.
Duh. It was present in the datasheet I had. Just downloaded last
version of the datasheet and it's no longer there.
Nicolas, there's still a reference to OVR2 in the block diagram
(Section "31.3 Block Diagram"), can ask fix that (or ask someone who
can).
>
> Fixes: 5b9fb5e6c6c7 ("drm: atmel-hlcdc: add support for sama5d4 SoCs")
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 20 +-------------------
> 1 file changed, 1 insertion(+), 19 deletions(-)
>
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> index 30dbffd..888524a 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> @@ -295,28 +295,10 @@ static const struct atmel_hlcdc_layer_desc atmel_hlcdc_sama5d4_layers[] = {
> },
> },
> {
> - .name = "overlay2",
> - .formats = &atmel_hlcdc_plane_rgb_formats,
> - .regs_offset = 0x240,
> - .id = 2,
> - .type = ATMEL_HLCDC_OVERLAY_LAYER,
> - .cfgs_offset = 0x2c,
> - .layout = {
> - .pos = 2,
> - .size = 3,
> - .xstride = { 4 },
> - .pstride = { 5 },
> - .default_color = 6,
> - .chroma_key = 7,
> - .chroma_key_mask = 8,
> - .general_config = 9,
> - },
> - },
> - {
> .name = "high-end-overlay",
> .formats = &atmel_hlcdc_plane_rgb_and_yuv_formats,
> .regs_offset = 0x340,
> - .id = 3,
> + .id = 2,
> .type = ATMEL_HLCDC_OVERLAY_LAYER,
> .cfgs_offset = 0x4c,
> .layout = {
next prev parent reply other threads:[~2017-06-15 9:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 9:24 [PATCH] drm: atmel-hlcdc: sama5d4 does not have overlay2 Peter Rosin
2017-06-15 9:37 ` Boris Brezillon [this message]
2017-06-15 22:40 ` Peter Rosin
2017-06-21 15:14 ` Nicolas Ferre
2017-06-21 16:36 ` Peter Rosin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170615113748.1c98f898@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=peda@axentia.se \
--cc=peda@lysator.liu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox