From: "Pali Rohár" <pali.rohar@gmail.com>
To: Mario.Limonciello@dell.com, Darren Hart <dvhart@infradead.org>
Cc: Andy Shevchenko <andy@infradead.org>,
Andy Lutomirski <luto@kernel.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number
Date: Thu, 15 Jun 2017 15:59:02 +0200 [thread overview]
Message-ID: <20170615135902.GS5248@pali> (raw)
In-Reply-To: <20170614154654.GA22981@pali>
Mario, are you able to check if instance number passed to
wmi_evaluate_method in following dell WMI drivers is correct and should
be really 1?
I suspect that it should be zero, as instance number is indexed from
zero.
There is no comment in those dell WMI drivers why it is 1, nor what 1
means.
Ideally it needs to be checked in ACPI byte code, MOF file and WDG dump.
On Wednesday 14 June 2017 17:46:54 Pali Rohár wrote:
> Function wmi_evaluate_method:
...
> alienware-wmi.c:
> instance=1 /* no comment why, guid=A70591CE-A997-11DA-B012-B622A1EF5492 */
> instance=1 /* no comment why, guid=A80593CE-A997-11DA-B012-B622A1EF5492 */
> instance=1 /* no comment why, guid=A70591CE-A997-11DA-B012-B622A1EF5492 */
...
> dell-wmi-led.c:
> instance=1 /* no comment why, guid=F6E4FE6E-909D-47cb-8BAB-C9F6F2F8D396 */
--
Pali Rohár
pali.rohar@gmail.com
next prev parent reply other threads:[~2017-06-15 13:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-27 11:55 [PATCH] RFC: platform/x86: wmi: Fix check for method instance number Pali Rohár
2017-06-10 19:15 ` Pali Rohár
2017-06-13 16:49 ` Darren Hart
2017-06-13 18:04 ` Pali Rohár
2017-06-13 18:42 ` Darren Hart
2017-06-14 15:46 ` Pali Rohár
2017-06-14 20:39 ` Darren Hart
2017-06-15 13:59 ` Pali Rohár [this message]
2017-06-15 15:16 ` Mario.Limonciello
2017-06-16 16:33 ` Mario.Limonciello
2017-06-17 16:34 ` Pali Rohár
2017-06-21 21:52 ` Mario.Limonciello
2017-06-22 7:33 ` Pali Rohár
2017-06-17 16:47 ` Pali Rohár
2017-06-19 15:02 ` joeyli
2017-07-05 9:51 ` Pali Rohár
2017-07-05 19:30 ` David Airlie
2017-07-05 20:24 ` Pali Rohár
2017-08-06 15:35 ` Pali Rohár
2017-08-06 16:10 ` Andy Shevchenko
2017-08-06 20:21 ` Pali Rohár
2017-08-06 15:42 ` Pali Rohár
2017-08-06 16:18 ` Hans de Goede
2017-08-06 20:16 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170615135902.GS5248@pali \
--to=pali.rohar@gmail.com \
--cc=Mario.Limonciello@dell.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).