From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752946AbdFOPDR (ORCPT ); Thu, 15 Jun 2017 11:03:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60444 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752387AbdFOPDQ (ORCPT ); Thu, 15 Jun 2017 11:03:16 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5748AB15B Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=bhe@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 5748AB15B Date: Thu, 15 Jun 2017 23:03:10 +0800 From: Baoquan He To: kbuild test robot Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, keescook@chromium.org, x86@kernel.org, fanc.fnst@cn.fujitsu.com, caoj.fnst@cn.fujitsu.com, douly.fnst@cn.fujitsu.com Subject: Re: [PATCH 2/2] x86/boot/KASLR: Restrict kernel to be randomized in mirror regions if existed Message-ID: <20170615150310.GD16181@x1> References: <1497513169-25283-3-git-send-email-bhe@redhat.com> <201706152200.8tTQydxV%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201706152200.8tTQydxV%fengguang.wu@intel.com> User-Agent: Mutt/1.7.0 (2016-08-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 15 Jun 2017 15:03:15 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/15/17 at 10:04pm, kbuild test robot wrote: > Hi Baoquan, > > [auto build test WARNING on tip/auto-latest] > [also build test WARNING on next-20170615] > [cannot apply to tip/x86/core v4.12-rc5] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Baoquan-He/x86-boot-KASLR-Restrict-kernel-to-be-randomized-in-mirror-regions-if-existed/20170615-204125 > config: i386-defconfig (attached as .config) > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > All warnings (new ones prefixed by >>): > > arch/x86/boot/compressed/kaslr.c: In function 'process_efi_entry': > >> arch/x86/boot/compressed/kaslr.c:604:24: warning: 'return' with a value, in function returning void > return -EINVAL; > ^ > arch/x86/boot/compressed/kaslr.c:566:13: note: declared here > static void process_efi_entry(unsigned long minimum, unsigned long image_size) > ^~~~~~~~~~~~~~~~~ > > vim +/return +604 arch/x86/boot/compressed/kaslr.c > > 588 > 589 /* > 590 * Mirrored regions are meaningful only if "kernelcore=mirror" > 591 * specified. > 592 */ > 593 str = strstr(cmdline, "kernelcore="); > 594 if (!str) > 595 return; > 596 str += strlen("kernelcore="); > 597 if (strncmp(str, "mirror", 6)) > 598 return; > 599 > 600 #ifdef CONFIG_X86_32 > 601 /* Can't handle data above 4GB at this time */ > 602 if (e->efi_memmap_hi) { > 603 warn("Memory map is above 4GB, disabling EFI.\n"); > > 604 return -EINVAL; Yeah, this need be changed. This patchset is not a formal one, there was unclear issue. Now it has been clarified, will repost a formal one after test on efi mirror machine passed. > 605 } > 606 pmap = e->efi_memmap; > 607 #else > 608 pmap = (e->efi_memmap | ((__u64)e->efi_memmap_hi << 32)); > 609 #endif > 610 > 611 nr_desc = e->efi_memmap_size / e->efi_memdesc_size; > 612 for (i = 0; i < nr_desc; i++) { > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation