From: Guenter Roeck <linux@roeck-us.net>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: wim@iguana.be, baoyou.xie@linaro.org,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: zx2967: constify zx2967_wdt_ops.
Date: Thu, 15 Jun 2017 10:26:30 -0700 [thread overview]
Message-ID: <20170615172630.GC7549@roeck-us.net> (raw)
In-Reply-To: <42bf28fa31b27477cc97cfca4b0a8bcdc83309f4.1497249031.git.arvind.yadav.cs@gmail.com>
On Mon, Jun 12, 2017 at 12:02:39PM +0530, Arvind Yadav wrote:
> File size before:
> text data bss dec hex filename
> 988 288 0 1276 4fc drivers/watchdog/zx2967_wdt.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 1084 192 0 1276 4fc drivers/watchdog/zx2967_wdt.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/zx2967_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/zx2967_wdt.c b/drivers/watchdog/zx2967_wdt.c
> index e290d5a..17774de 100644
> --- a/drivers/watchdog/zx2967_wdt.c
> +++ b/drivers/watchdog/zx2967_wdt.c
> @@ -154,7 +154,7 @@ static int zx2967_wdt_keepalive(struct watchdog_device *wdd)
> .identity = "zx2967 watchdog",
> };
>
> -static struct watchdog_ops zx2967_wdt_ops = {
> +static const struct watchdog_ops zx2967_wdt_ops = {
> .owner = THIS_MODULE,
> .start = zx2967_wdt_start,
> .stop = zx2967_wdt_stop,
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-06-15 17:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 6:32 [PATCH] watchdog: zx2967: constify zx2967_wdt_ops Arvind Yadav
2017-06-15 17:26 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170615172630.GC7549@roeck-us.net \
--to=linux@roeck-us.net \
--cc=arvind.yadav.cs@gmail.com \
--cc=baoyou.xie@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox