From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: peterz@infradead.org, paulmck@linux.vnet.ibm.com,
oleg@redhat.com, josh@joshtriplett.org, rostedt@goodmis.org,
mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com
Cc: paul.gortmaker@windriver.com, ebiederm@xmission.com,
dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org,
"Luis R. Rodriguez" <mcgrof@kernel.org>
Subject: [RFC v2 0/2] swait: add idle to make idle-hacks on kthreads explicit
Date: Thu, 15 Jun 2017 11:48:18 -0700 [thread overview]
Message-ID: <20170615184820.22994-1-mcgrof@kernel.org> (raw)
In-Reply-To: <87zid92ns2.fsf@xmission.com>
While reviewing RCU's interruptible swaits I noticed signals were actually
not expected. Paul explained that the reason signals are not expected is
we use kthreads, which don't get signals, furthermore the code avoided the
uninterruptible swaits as otherwise it would contribute to the system load
average on idle, bumping it from 0 to 2 or 3 (depending on preemption).
Since this can be confusing its best to be explicit about the requirements and
goals. This patch depends on the other killable swaits [0] recently proposed as
well interms of context. Thee patch can however be tested independently if
the hunk is addressed separately.
[0] https://lkml.kernel.org/r/20170614222017.14653-3-mcgrof@kernel.org
Luis R. Rodriguez (2):
swait: add idle variants which don't contribute to load average
rcu: use idle versions of swait to make idle-hack clear
include/linux/swait.h | 25 +++++++++++++++++++++++++
kernel/rcu/tree.c | 4 ++--
2 files changed, 27 insertions(+), 2 deletions(-)
--
2.11.0
next prev parent reply other threads:[~2017-06-15 18:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 23:06 [RFC] rcu: use killable versions of swait Luis R. Rodriguez
2017-06-14 23:43 ` Paul E. McKenney
2017-06-15 15:50 ` Luis R. Rodriguez
2017-06-15 16:22 ` Paul E. McKenney
2017-06-15 16:35 ` Luis R. Rodriguez
2017-06-15 16:55 ` Eric W. Biederman
2017-06-15 18:48 ` Luis R. Rodriguez [this message]
2017-06-15 18:48 ` [RFC v2 1/2] swait: add idle variants which don't contribute to load average Luis R. Rodriguez
2017-06-16 0:47 ` Boqun Feng
2017-06-20 21:32 ` Luis R. Rodriguez
2017-06-16 20:31 ` Eric W. Biederman
2017-06-19 17:53 ` Paul E. McKenney
2017-06-15 18:48 ` [RFC v2 2/2] rcu: use idle versions of swait to make idle-hack clear Luis R. Rodriguez
2017-06-15 21:57 ` [RFC v2 0/2] swait: add idle to make idle-hacks on kthreads explicit Paul E. McKenney
2017-06-15 23:26 ` Luis R. Rodriguez
2017-06-15 23:43 ` Paul E. McKenney
2017-06-16 20:37 ` Eric W. Biederman
2017-06-19 17:54 ` Paul E. McKenney
2017-06-20 21:45 ` [PATCH " Luis R. Rodriguez
2017-06-20 21:45 ` [PATCH 1/2] swait: add idle variants which don't contribute to load average Luis R. Rodriguez
2017-06-20 21:45 ` [PATCH 2/2] rcu: use idle versions of swait to make idle-hack clear Luis R. Rodriguez
2017-06-21 16:48 ` [PATCH 0/2] swait: add idle to make idle-hacks on kthreads explicit Paul E. McKenney
2017-06-21 17:57 ` Luis R. Rodriguez
2017-06-21 18:19 ` Paul E. McKenney
2017-06-15 17:34 ` [RFC] rcu: use killable versions of swait Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170615184820.22994-1-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=ebiederm@xmission.com \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=oleg@redhat.com \
--cc=paul.gortmaker@windriver.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox