From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753160AbdFPMM7 (ORCPT ); Fri, 16 Jun 2017 08:12:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56190 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753042AbdFPMM5 (ORCPT ); Fri, 16 Jun 2017 08:12:57 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 702B47E9C1 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=none smtp.mailfrom=jolsa@kernel.org DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 702B47E9C1 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: He Kuang , lkml , Ingo Molnar , Peter Zijlstra , Namhyung Kim , David Ahern Subject: [PATCH] perf unwind: Limit warnings when asked for not supported unwind Date: Fri, 16 Jun 2017 14:12:53 +0200 Message-Id: <20170616121253.3816-1-jolsa@kernel.org> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 16 Jun 2017 12:12:56 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ingo reported following warning flooding the report out: unwind: target platform=x86 is not supported We trigger this warning when the dwarf unwinder is asked to process architecture which wasn't compiled in, like when you get 32bit application samples on your 64bit server and you don't have the 32bit remote unwind support compiled in. This patch limits the warning to single message for arch, and adds bits info. Above message is changed to: unwind: target platform=x86 32bit is not supported Cc: He Kuang Signed-off-by: Jiri Olsa --- tools/perf/util/unwind-libunwind.c | 29 ++++++++++++++++++++++++----- 1 file changed, 24 insertions(+), 5 deletions(-) diff --git a/tools/perf/util/unwind-libunwind.c b/tools/perf/util/unwind-libunwind.c index 6d542a4e0648..1439a6bcfa07 100644 --- a/tools/perf/util/unwind-libunwind.c +++ b/tools/perf/util/unwind-libunwind.c @@ -1,12 +1,24 @@ +#include #include "unwind.h" #include "thread.h" #include "session.h" #include "debug.h" #include "arch/common.h" -struct unwind_libunwind_ops __weak *local_unwind_libunwind_ops; -struct unwind_libunwind_ops __weak *x86_32_unwind_libunwind_ops; -struct unwind_libunwind_ops __weak *arm64_unwind_libunwind_ops; +enum { + ERR_LOCAL = 0, + ERR_X86_32 = 1, + ERR_ARM64 = 2, +}; + +/* + * Set default error values, so we can warn appropriately when + * the support is not compiled in. Using negative values so we + * can use ERR macros. + */ +struct unwind_libunwind_ops __weak *local_unwind_libunwind_ops = (void *) -ERR_LOCAL; +struct unwind_libunwind_ops __weak *x86_32_unwind_libunwind_ops = (void *) -ERR_X86_32; +struct unwind_libunwind_ops __weak *arm64_unwind_libunwind_ops = (void *) -ERR_ARM64; static void unwind__register_ops(struct thread *thread, struct unwind_libunwind_ops *ops) @@ -48,8 +60,15 @@ int unwind__prepare_access(struct thread *thread, struct map *map, ops = arm64_unwind_libunwind_ops; } - if (!ops) { - pr_err("unwind: target platform=%s is not supported\n", arch); + if (IS_ERR(ops)) { + static unsigned long warned; + long bit = -PTR_ERR(ops); + + if (!test_and_set_bit(bit, &warned)) { + pr_err("unwind: target platform=%s %dbit is not supported\n", + arch, dso_type == DSO__TYPE_64BIT ? 64 : 32); + } + return -1; } out_register: -- 2.9.4