From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754223AbdFPObc (ORCPT ); Fri, 16 Jun 2017 10:31:32 -0400 Received: from mail-io0-f174.google.com ([209.85.223.174]:36146 "EHLO mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753715AbdFPOba (ORCPT ); Fri, 16 Jun 2017 10:31:30 -0400 Date: Fri, 16 Jun 2017 08:31:25 -0600 From: Mathieu Poirier To: Kim Phillips Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] perf coresight: Remove superfluous check before use Message-ID: <20170616143125.GA30102@xps15> References: <20170615125521.80cc128dc856bc1f2e61b730@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170615125521.80cc128dc856bc1f2e61b730@arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 15, 2017 at 12:55:21PM -0500, Kim Phillips wrote: > cs_etm_evsel is guaranteed to be set at this point in the function. > > Signed-off-by: Kim Phillips > --- > tools/perf/arch/arm/util/cs-etm.c | 25 ++++++++++++------------- > 1 file changed, 12 insertions(+), 13 deletions(-) > > diff --git a/tools/perf/arch/arm/util/cs-etm.c b/tools/perf/arch/arm/util/cs-etm.c > index 29361d9b635a..8e1e9469caf2 100644 > --- a/tools/perf/arch/arm/util/cs-etm.c > +++ b/tools/perf/arch/arm/util/cs-etm.c > @@ -202,19 +202,18 @@ static int cs_etm_recording_options(struct auxtrace_record *itr, > pr_debug2("%s snapshot size: %zu\n", CORESIGHT_ETM_PMU_NAME, > opts->auxtrace_snapshot_size); > > - if (cs_etm_evsel) { > - /* > - * To obtain the auxtrace buffer file descriptor, the auxtrace > - * event must come first. > - */ > - perf_evlist__to_front(evlist, cs_etm_evsel); > - /* > - * In the case of per-cpu mmaps, we need the CPU on the > - * AUX event. > - */ > - if (!cpu_map__empty(cpus)) > - perf_evsel__set_sample_bit(cs_etm_evsel, CPU); > - } > + /* > + * To obtain the auxtrace buffer file descriptor, the auxtrace > + * event must come first. > + */ > + perf_evlist__to_front(evlist, cs_etm_evsel); > + > + /* > + * In the case of per-cpu mmaps, we need the CPU on the > + * AUX event. > + */ > + if (!cpu_map__empty(cpus)) > + perf_evsel__set_sample_bit(cs_etm_evsel, CPU); Acked-by: Mathieu Poirier > > /* Add dummy event to keep tracking */ > if (opts->full_auxtrace) { > -- > 2.11.0 >