From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750983AbdFPQ11 (ORCPT ); Fri, 16 Jun 2017 12:27:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:48288 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750750AbdFPQ10 (ORCPT ); Fri, 16 Jun 2017 12:27:26 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B75BC219A9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Fri, 16 Jun 2017 13:27:23 -0300 From: Arnaldo Carvalho de Melo To: Kim Phillips Cc: Ingo Molnar , Adrian Hunter , Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Andi Kleen , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2 v2] perf intel-pt/bts: remove unused SAMPLE_SIZE defines and bts priv array Message-ID: <20170616162723.GK3645@kernel.org> References: <20170615125514.58399e95ea099fdec244b36f@arm.com> <174ce49b-d0f9-9c0c-013e-d110a0494b41@intel.com> <20170616080653.syjkvtgwtzmfsfgd@gmail.com> <20170616112339.3fb6986e4ff33e353008244b@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170616112339.3fb6986e4ff33e353008244b@arm.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Jun 16, 2017 at 11:23:39AM -0500, Kim Phillips escreveu: > These defines were probably dragged in from sampling support in earlier > patches. They can be put back when needed. Applied. Ah, please capitalize the first word after the : in the summary, i.e.: [PATCH 1/2 v2] perf intel-pt/bts: Remove unused SAMPLE_SIZE Thanks, - Arnaldo > Acked-by: Adrian Hunter > Signed-off-by: Kim Phillips > --- > v2: addressed Ingo's comment by populating changelog with Adrian's > explanation of why they were unused > > tools/perf/arch/x86/util/intel-bts.c | 4 ---- > tools/perf/arch/x86/util/intel-pt.c | 4 ---- > tools/perf/util/intel-bts.c | 2 -- > 3 files changed, 10 deletions(-) > > diff --git a/tools/perf/arch/x86/util/intel-bts.c b/tools/perf/arch/x86/util/intel-bts.c > index af2bce7a2cd6..781df40b2966 100644 > --- a/tools/perf/arch/x86/util/intel-bts.c > +++ b/tools/perf/arch/x86/util/intel-bts.c > @@ -35,10 +35,6 @@ > #define KiB_MASK(x) (KiB(x) - 1) > #define MiB_MASK(x) (MiB(x) - 1) > > -#define INTEL_BTS_DFLT_SAMPLE_SIZE KiB(4) > - > -#define INTEL_BTS_MAX_SAMPLE_SIZE KiB(60) > - > struct intel_bts_snapshot_ref { > void *ref_buf; > size_t ref_offset; > diff --git a/tools/perf/arch/x86/util/intel-pt.c b/tools/perf/arch/x86/util/intel-pt.c > index f630de0206a1..6fe667b3269e 100644 > --- a/tools/perf/arch/x86/util/intel-pt.c > +++ b/tools/perf/arch/x86/util/intel-pt.c > @@ -40,10 +40,6 @@ > #define KiB_MASK(x) (KiB(x) - 1) > #define MiB_MASK(x) (MiB(x) - 1) > > -#define INTEL_PT_DEFAULT_SAMPLE_SIZE KiB(4) > - > -#define INTEL_PT_MAX_SAMPLE_SIZE KiB(60) > - > #define INTEL_PT_PSB_PERIOD_NEAR 256 > > struct intel_pt_snapshot_ref { > diff --git a/tools/perf/util/intel-bts.c b/tools/perf/util/intel-bts.c > index b2834ac7b1f5..218ee2bac9a5 100644 > --- a/tools/perf/util/intel-bts.c > +++ b/tools/perf/util/intel-bts.c > @@ -866,8 +866,6 @@ static void intel_bts_print_info(u64 *arr, int start, int finish) > fprintf(stdout, intel_bts_info_fmts[i], arr[i]); > } > > -u64 intel_bts_auxtrace_info_priv[INTEL_BTS_AUXTRACE_PRIV_SIZE]; > - > int intel_bts_process_auxtrace_info(union perf_event *event, > struct perf_session *session) > { > -- > 2.11.0