* [PATCH 1/2] perf intel-pt/bts: remove unused SAMPLE_SIZE defines and bts priv array
@ 2017-06-15 17:55 Kim Phillips
2017-06-16 6:43 ` Adrian Hunter
0 siblings, 1 reply; 6+ messages in thread
From: Kim Phillips @ 2017-06-15 17:55 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Alexander Shishkin, Adrian Hunter, Andi Kleen
Cc: linux-kernel
Signed-off-by: Kim Phillips <kim.phillips@arm.com>
---
tools/perf/arch/x86/util/intel-bts.c | 4 ----
tools/perf/arch/x86/util/intel-pt.c | 4 ----
tools/perf/util/intel-bts.c | 2 --
3 files changed, 10 deletions(-)
diff --git a/tools/perf/arch/x86/util/intel-bts.c b/tools/perf/arch/x86/util/intel-bts.c
index af2bce7a2cd6..781df40b2966 100644
--- a/tools/perf/arch/x86/util/intel-bts.c
+++ b/tools/perf/arch/x86/util/intel-bts.c
@@ -35,10 +35,6 @@
#define KiB_MASK(x) (KiB(x) - 1)
#define MiB_MASK(x) (MiB(x) - 1)
-#define INTEL_BTS_DFLT_SAMPLE_SIZE KiB(4)
-
-#define INTEL_BTS_MAX_SAMPLE_SIZE KiB(60)
-
struct intel_bts_snapshot_ref {
void *ref_buf;
size_t ref_offset;
diff --git a/tools/perf/arch/x86/util/intel-pt.c b/tools/perf/arch/x86/util/intel-pt.c
index f630de0206a1..6fe667b3269e 100644
--- a/tools/perf/arch/x86/util/intel-pt.c
+++ b/tools/perf/arch/x86/util/intel-pt.c
@@ -40,10 +40,6 @@
#define KiB_MASK(x) (KiB(x) - 1)
#define MiB_MASK(x) (MiB(x) - 1)
-#define INTEL_PT_DEFAULT_SAMPLE_SIZE KiB(4)
-
-#define INTEL_PT_MAX_SAMPLE_SIZE KiB(60)
-
#define INTEL_PT_PSB_PERIOD_NEAR 256
struct intel_pt_snapshot_ref {
diff --git a/tools/perf/util/intel-bts.c b/tools/perf/util/intel-bts.c
index b2834ac7b1f5..218ee2bac9a5 100644
--- a/tools/perf/util/intel-bts.c
+++ b/tools/perf/util/intel-bts.c
@@ -866,8 +866,6 @@ static void intel_bts_print_info(u64 *arr, int start, int finish)
fprintf(stdout, intel_bts_info_fmts[i], arr[i]);
}
-u64 intel_bts_auxtrace_info_priv[INTEL_BTS_AUXTRACE_PRIV_SIZE];
-
int intel_bts_process_auxtrace_info(union perf_event *event,
struct perf_session *session)
{
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] perf intel-pt/bts: remove unused SAMPLE_SIZE defines and bts priv array
2017-06-15 17:55 [PATCH 1/2] perf intel-pt/bts: remove unused SAMPLE_SIZE defines and bts priv array Kim Phillips
@ 2017-06-16 6:43 ` Adrian Hunter
2017-06-16 8:06 ` Ingo Molnar
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Hunter @ 2017-06-16 6:43 UTC (permalink / raw)
To: Kim Phillips, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Alexander Shishkin, Andi Kleen
Cc: linux-kernel
On 15/06/17 20:55, Kim Phillips wrote:
>
> Signed-off-by: Kim Phillips <kim.phillips@arm.com>
Looks like defines for sampling support that got mixed in with earlier
patches. We can always put them back when we need them, so:
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> tools/perf/arch/x86/util/intel-bts.c | 4 ----
> tools/perf/arch/x86/util/intel-pt.c | 4 ----
> tools/perf/util/intel-bts.c | 2 --
> 3 files changed, 10 deletions(-)
>
> diff --git a/tools/perf/arch/x86/util/intel-bts.c b/tools/perf/arch/x86/util/intel-bts.c
> index af2bce7a2cd6..781df40b2966 100644
> --- a/tools/perf/arch/x86/util/intel-bts.c
> +++ b/tools/perf/arch/x86/util/intel-bts.c
> @@ -35,10 +35,6 @@
> #define KiB_MASK(x) (KiB(x) - 1)
> #define MiB_MASK(x) (MiB(x) - 1)
>
> -#define INTEL_BTS_DFLT_SAMPLE_SIZE KiB(4)
> -
> -#define INTEL_BTS_MAX_SAMPLE_SIZE KiB(60)
> -
> struct intel_bts_snapshot_ref {
> void *ref_buf;
> size_t ref_offset;
> diff --git a/tools/perf/arch/x86/util/intel-pt.c b/tools/perf/arch/x86/util/intel-pt.c
> index f630de0206a1..6fe667b3269e 100644
> --- a/tools/perf/arch/x86/util/intel-pt.c
> +++ b/tools/perf/arch/x86/util/intel-pt.c
> @@ -40,10 +40,6 @@
> #define KiB_MASK(x) (KiB(x) - 1)
> #define MiB_MASK(x) (MiB(x) - 1)
>
> -#define INTEL_PT_DEFAULT_SAMPLE_SIZE KiB(4)
> -
> -#define INTEL_PT_MAX_SAMPLE_SIZE KiB(60)
> -
> #define INTEL_PT_PSB_PERIOD_NEAR 256
>
> struct intel_pt_snapshot_ref {
> diff --git a/tools/perf/util/intel-bts.c b/tools/perf/util/intel-bts.c
> index b2834ac7b1f5..218ee2bac9a5 100644
> --- a/tools/perf/util/intel-bts.c
> +++ b/tools/perf/util/intel-bts.c
> @@ -866,8 +866,6 @@ static void intel_bts_print_info(u64 *arr, int start, int finish)
> fprintf(stdout, intel_bts_info_fmts[i], arr[i]);
> }
>
> -u64 intel_bts_auxtrace_info_priv[INTEL_BTS_AUXTRACE_PRIV_SIZE];
> -
> int intel_bts_process_auxtrace_info(union perf_event *event,
> struct perf_session *session)
> {
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] perf intel-pt/bts: remove unused SAMPLE_SIZE defines and bts priv array
2017-06-16 6:43 ` Adrian Hunter
@ 2017-06-16 8:06 ` Ingo Molnar
2017-06-16 16:23 ` [PATCH 1/2 v2] " Kim Phillips
0 siblings, 1 reply; 6+ messages in thread
From: Ingo Molnar @ 2017-06-16 8:06 UTC (permalink / raw)
To: Adrian Hunter
Cc: Kim Phillips, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Alexander Shishkin, Andi Kleen,
linux-kernel
* Adrian Hunter <adrian.hunter@intel.com> wrote:
> On 15/06/17 20:55, Kim Phillips wrote:
> >
> > Signed-off-by: Kim Phillips <kim.phillips@arm.com>
>
> Looks like defines for sampling support that got mixed in with earlier
> patches. We can always put them back when we need them, so:
>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
The non-existent changelog is wholly inadequate though.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2 v2] perf intel-pt/bts: remove unused SAMPLE_SIZE defines and bts priv array
2017-06-16 8:06 ` Ingo Molnar
@ 2017-06-16 16:23 ` Kim Phillips
2017-06-16 16:27 ` Arnaldo Carvalho de Melo
2017-06-20 9:02 ` [tip:perf/core] perf intel-pt/bts: Remove " tip-bot for Kim Phillips
0 siblings, 2 replies; 6+ messages in thread
From: Kim Phillips @ 2017-06-16 16:23 UTC (permalink / raw)
To: Ingo Molnar
Cc: Adrian Hunter, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Alexander Shishkin, Andi Kleen,
linux-kernel
These defines were probably dragged in from sampling support in earlier
patches. They can be put back when needed.
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Kim Phillips <kim.phillips@arm.com>
---
v2: addressed Ingo's comment by populating changelog with Adrian's
explanation of why they were unused
tools/perf/arch/x86/util/intel-bts.c | 4 ----
tools/perf/arch/x86/util/intel-pt.c | 4 ----
tools/perf/util/intel-bts.c | 2 --
3 files changed, 10 deletions(-)
diff --git a/tools/perf/arch/x86/util/intel-bts.c b/tools/perf/arch/x86/util/intel-bts.c
index af2bce7a2cd6..781df40b2966 100644
--- a/tools/perf/arch/x86/util/intel-bts.c
+++ b/tools/perf/arch/x86/util/intel-bts.c
@@ -35,10 +35,6 @@
#define KiB_MASK(x) (KiB(x) - 1)
#define MiB_MASK(x) (MiB(x) - 1)
-#define INTEL_BTS_DFLT_SAMPLE_SIZE KiB(4)
-
-#define INTEL_BTS_MAX_SAMPLE_SIZE KiB(60)
-
struct intel_bts_snapshot_ref {
void *ref_buf;
size_t ref_offset;
diff --git a/tools/perf/arch/x86/util/intel-pt.c b/tools/perf/arch/x86/util/intel-pt.c
index f630de0206a1..6fe667b3269e 100644
--- a/tools/perf/arch/x86/util/intel-pt.c
+++ b/tools/perf/arch/x86/util/intel-pt.c
@@ -40,10 +40,6 @@
#define KiB_MASK(x) (KiB(x) - 1)
#define MiB_MASK(x) (MiB(x) - 1)
-#define INTEL_PT_DEFAULT_SAMPLE_SIZE KiB(4)
-
-#define INTEL_PT_MAX_SAMPLE_SIZE KiB(60)
-
#define INTEL_PT_PSB_PERIOD_NEAR 256
struct intel_pt_snapshot_ref {
diff --git a/tools/perf/util/intel-bts.c b/tools/perf/util/intel-bts.c
index b2834ac7b1f5..218ee2bac9a5 100644
--- a/tools/perf/util/intel-bts.c
+++ b/tools/perf/util/intel-bts.c
@@ -866,8 +866,6 @@ static void intel_bts_print_info(u64 *arr, int start, int finish)
fprintf(stdout, intel_bts_info_fmts[i], arr[i]);
}
-u64 intel_bts_auxtrace_info_priv[INTEL_BTS_AUXTRACE_PRIV_SIZE];
-
int intel_bts_process_auxtrace_info(union perf_event *event,
struct perf_session *session)
{
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2 v2] perf intel-pt/bts: remove unused SAMPLE_SIZE defines and bts priv array
2017-06-16 16:23 ` [PATCH 1/2 v2] " Kim Phillips
@ 2017-06-16 16:27 ` Arnaldo Carvalho de Melo
2017-06-20 9:02 ` [tip:perf/core] perf intel-pt/bts: Remove " tip-bot for Kim Phillips
1 sibling, 0 replies; 6+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-06-16 16:27 UTC (permalink / raw)
To: Kim Phillips
Cc: Ingo Molnar, Adrian Hunter, Peter Zijlstra, Ingo Molnar,
Alexander Shishkin, Andi Kleen, linux-kernel
Em Fri, Jun 16, 2017 at 11:23:39AM -0500, Kim Phillips escreveu:
> These defines were probably dragged in from sampling support in earlier
> patches. They can be put back when needed.
Applied.
Ah, please capitalize the first word after the : in the summary, i.e.:
[PATCH 1/2 v2] perf intel-pt/bts: Remove unused SAMPLE_SIZE
Thanks,
- Arnaldo
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> Signed-off-by: Kim Phillips <kim.phillips@arm.com>
> ---
> v2: addressed Ingo's comment by populating changelog with Adrian's
> explanation of why they were unused
>
> tools/perf/arch/x86/util/intel-bts.c | 4 ----
> tools/perf/arch/x86/util/intel-pt.c | 4 ----
> tools/perf/util/intel-bts.c | 2 --
> 3 files changed, 10 deletions(-)
>
> diff --git a/tools/perf/arch/x86/util/intel-bts.c b/tools/perf/arch/x86/util/intel-bts.c
> index af2bce7a2cd6..781df40b2966 100644
> --- a/tools/perf/arch/x86/util/intel-bts.c
> +++ b/tools/perf/arch/x86/util/intel-bts.c
> @@ -35,10 +35,6 @@
> #define KiB_MASK(x) (KiB(x) - 1)
> #define MiB_MASK(x) (MiB(x) - 1)
>
> -#define INTEL_BTS_DFLT_SAMPLE_SIZE KiB(4)
> -
> -#define INTEL_BTS_MAX_SAMPLE_SIZE KiB(60)
> -
> struct intel_bts_snapshot_ref {
> void *ref_buf;
> size_t ref_offset;
> diff --git a/tools/perf/arch/x86/util/intel-pt.c b/tools/perf/arch/x86/util/intel-pt.c
> index f630de0206a1..6fe667b3269e 100644
> --- a/tools/perf/arch/x86/util/intel-pt.c
> +++ b/tools/perf/arch/x86/util/intel-pt.c
> @@ -40,10 +40,6 @@
> #define KiB_MASK(x) (KiB(x) - 1)
> #define MiB_MASK(x) (MiB(x) - 1)
>
> -#define INTEL_PT_DEFAULT_SAMPLE_SIZE KiB(4)
> -
> -#define INTEL_PT_MAX_SAMPLE_SIZE KiB(60)
> -
> #define INTEL_PT_PSB_PERIOD_NEAR 256
>
> struct intel_pt_snapshot_ref {
> diff --git a/tools/perf/util/intel-bts.c b/tools/perf/util/intel-bts.c
> index b2834ac7b1f5..218ee2bac9a5 100644
> --- a/tools/perf/util/intel-bts.c
> +++ b/tools/perf/util/intel-bts.c
> @@ -866,8 +866,6 @@ static void intel_bts_print_info(u64 *arr, int start, int finish)
> fprintf(stdout, intel_bts_info_fmts[i], arr[i]);
> }
>
> -u64 intel_bts_auxtrace_info_priv[INTEL_BTS_AUXTRACE_PRIV_SIZE];
> -
> int intel_bts_process_auxtrace_info(union perf_event *event,
> struct perf_session *session)
> {
> --
> 2.11.0
^ permalink raw reply [flat|nested] 6+ messages in thread* [tip:perf/core] perf intel-pt/bts: Remove unused SAMPLE_SIZE defines and bts priv array
2017-06-16 16:23 ` [PATCH 1/2 v2] " Kim Phillips
2017-06-16 16:27 ` Arnaldo Carvalho de Melo
@ 2017-06-20 9:02 ` tip-bot for Kim Phillips
1 sibling, 0 replies; 6+ messages in thread
From: tip-bot for Kim Phillips @ 2017-06-20 9:02 UTC (permalink / raw)
To: linux-tip-commits
Cc: hpa, linux-kernel, peterz, ak, mingo, acme, adrian.hunter, tglx,
alexander.shishkin, kim.phillips
Commit-ID: d3cef7fe5151eabcd97ad8f9e595ec55f6ffb318
Gitweb: http://git.kernel.org/tip/d3cef7fe5151eabcd97ad8f9e595ec55f6ffb318
Author: Kim Phillips <kim.phillips@arm.com>
AuthorDate: Fri, 16 Jun 2017 11:23:39 -0500
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 19 Jun 2017 15:27:09 -0300
perf intel-pt/bts: Remove unused SAMPLE_SIZE defines and bts priv array
These defines were probably dragged in from sampling support in earlier
patches. They can be put back when needed.
Signed-off-by: Kim Phillips <kim.phillips@arm.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20170616112339.3fb6986e4ff33e353008244b@arm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/arch/x86/util/intel-bts.c | 4 ----
tools/perf/arch/x86/util/intel-pt.c | 4 ----
tools/perf/util/intel-bts.c | 2 --
3 files changed, 10 deletions(-)
diff --git a/tools/perf/arch/x86/util/intel-bts.c b/tools/perf/arch/x86/util/intel-bts.c
index af2bce7..781df40 100644
--- a/tools/perf/arch/x86/util/intel-bts.c
+++ b/tools/perf/arch/x86/util/intel-bts.c
@@ -35,10 +35,6 @@
#define KiB_MASK(x) (KiB(x) - 1)
#define MiB_MASK(x) (MiB(x) - 1)
-#define INTEL_BTS_DFLT_SAMPLE_SIZE KiB(4)
-
-#define INTEL_BTS_MAX_SAMPLE_SIZE KiB(60)
-
struct intel_bts_snapshot_ref {
void *ref_buf;
size_t ref_offset;
diff --git a/tools/perf/arch/x86/util/intel-pt.c b/tools/perf/arch/x86/util/intel-pt.c
index f630de0..6fe667b 100644
--- a/tools/perf/arch/x86/util/intel-pt.c
+++ b/tools/perf/arch/x86/util/intel-pt.c
@@ -40,10 +40,6 @@
#define KiB_MASK(x) (KiB(x) - 1)
#define MiB_MASK(x) (MiB(x) - 1)
-#define INTEL_PT_DEFAULT_SAMPLE_SIZE KiB(4)
-
-#define INTEL_PT_MAX_SAMPLE_SIZE KiB(60)
-
#define INTEL_PT_PSB_PERIOD_NEAR 256
struct intel_pt_snapshot_ref {
diff --git a/tools/perf/util/intel-bts.c b/tools/perf/util/intel-bts.c
index b2834ac..218ee2b 100644
--- a/tools/perf/util/intel-bts.c
+++ b/tools/perf/util/intel-bts.c
@@ -866,8 +866,6 @@ static void intel_bts_print_info(u64 *arr, int start, int finish)
fprintf(stdout, intel_bts_info_fmts[i], arr[i]);
}
-u64 intel_bts_auxtrace_info_priv[INTEL_BTS_AUXTRACE_PRIV_SIZE];
-
int intel_bts_process_auxtrace_info(union perf_event *event,
struct perf_session *session)
{
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-06-20 9:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-15 17:55 [PATCH 1/2] perf intel-pt/bts: remove unused SAMPLE_SIZE defines and bts priv array Kim Phillips
2017-06-16 6:43 ` Adrian Hunter
2017-06-16 8:06 ` Ingo Molnar
2017-06-16 16:23 ` [PATCH 1/2 v2] " Kim Phillips
2017-06-16 16:27 ` Arnaldo Carvalho de Melo
2017-06-20 9:02 ` [tip:perf/core] perf intel-pt/bts: Remove " tip-bot for Kim Phillips
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).