From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Okash Khawaja <okash.khawaja@gmail.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
Jiri Slaby <jslaby@suse.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
devel@driverdev.osuosl.org, Kirk Reiser <kirk@reisers.ca>,
speakup@linux-speakup.org, Chris Brannon <chris@the-brannons.com>
Subject: Re: [patch 1/2] staging: speakup: add function to convert dev name to number
Date: Sat, 17 Jun 2017 12:25:34 +0200 [thread overview]
Message-ID: <20170617102534.GA24564@kroah.com> (raw)
In-Reply-To: <20170617101644.GA31565@sanghar>
On Sat, Jun 17, 2017 at 11:16:44AM +0100, Okash Khawaja wrote:
> Hi,
>
> On Thu, Jun 15, 2017 at 07:52:51AM +0100, Okash Khawaja wrote:
> > On Wed, Jun 14, 2017 at 03:04:18PM +0200, Greg Kroah-Hartman wrote:
> > > The console stuff is odd though, but that is each driver defining the
> > > name for itself, major/minor does not apply. Also, a separate driver is
> > > not having to figure this all out. I wonder if we could just add a tty
> > > core function for this as it does know the name of everything that has
> > > been registered with it, right?
> >
> > I can start working on a patch for this. I'm still new to the tty code
> > so will follow up with any questions I might have.
>
> I've put together this function for converting device name to number.
> It traverses tty_drivers list looking for corresponding dev name and
> index. Is this the right approach?
Yes, this looks great, nice job! It is a lot simpler than your previous
function, and now you are not limited to just a subset off the different
serial ports in the system.
Keep up the good work, it's really appreciated.
greg k-h
next prev parent reply other threads:[~2017-06-17 10:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 22:37 [patch 0/2] staging: speakup: support more than ttyS* okash.khawaja
2017-06-13 22:37 ` [patch 1/2] staging: speakup: add function to convert dev name to number okash.khawaja
2017-06-14 8:23 ` Dan Carpenter
2017-06-15 8:17 ` Okash Khawaja
2017-06-14 10:13 ` Greg Kroah-Hartman
2017-06-14 10:15 ` Greg Kroah-Hartman
2017-06-14 11:26 ` Samuel Thibault
2017-06-14 11:48 ` Greg Kroah-Hartman
2017-06-14 12:18 ` Samuel Thibault
2017-06-14 12:36 ` Andy Shevchenko
2017-06-14 12:46 ` Samuel Thibault
2017-06-14 13:04 ` Greg Kroah-Hartman
2017-06-15 6:52 ` Okash Khawaja
2017-06-17 10:16 ` Okash Khawaja
2017-06-17 10:25 ` Greg Kroah-Hartman [this message]
2017-06-17 10:57 ` Okash Khawaja
2017-06-13 22:37 ` [patch 2/2] staging: speakup: make ttyio synths use device name okash.khawaja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170617102534.GA24564@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=jslaby@suse.com \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=okash.khawaja@gmail.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).