From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752298AbdFQQem (ORCPT ); Sat, 17 Jun 2017 12:34:42 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:36462 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750720AbdFQQej (ORCPT ); Sat, 17 Jun 2017 12:34:39 -0400 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Mario.Limonciello@dell.com Subject: Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number Date: Sat, 17 Jun 2017 18:34:36 +0200 User-Agent: KMail/1.13.7 (Linux/3.13.0-117-generic; KDE/4.14.2; x86_64; ; ) Cc: dvhart@infradead.org, andy@infradead.org, luto@kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <1495886134-8276-1-git-send-email-pali.rohar@gmail.com> <20170615135902.GS5248@pali> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1587285.rm0S5OEJtb"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201706171834.36487@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart1587285.rm0S5OEJtb Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Friday 16 June 2017 18:33:54 Mario.Limonciello@dell.com wrote: > > -----Original Message----- > > From: Limonciello, Mario > > Sent: Thursday, June 15, 2017 10:16 AM > > To: 'Pali Roh=C3=A1r' ; Darren Hart > > Cc: Andy Shevchenko ; > > Andy Lutomirski ; > > platform-driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org > > Subject: RE: [PATCH] RFC: platform/x86: wmi: Fix check for method > > instance number > >=20 > > > -----Original Message----- > > > From: Pali Roh=C3=A1r [mailto:pali.rohar@gmail.com] > > > Sent: Thursday, June 15, 2017 8:59 AM > > > To: Limonciello, Mario ; Darren Hart > > > > > > Cc: Andy Shevchenko ; Andy Lutomirski > >=20 > > ; > >=20 > > > platform-driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org > > > Subject: Re: [PATCH] RFC: platform/x86: wmi: Fix check for method > > > instance number > > >=20 > > > Mario, are you able to check if instance number passed to > > > wmi_evaluate_method in following dell WMI drivers is correct and > > > should be really 1? > > >=20 > > > I suspect that it should be zero, as instance number is indexed > > > from zero. > > >=20 > > > There is no comment in those dell WMI drivers why it is 1, nor > > > what 1 means. > > >=20 > > > Ideally it needs to be checked in ACPI byte code, MOF file and > > > WDG dump. > >=20 > > I think you're likely correct. I don't have a box that supports > > alienware-wmi or dell-wmi-led.c handy at the current moment to > > confirm this hypothesis though. I'll confirm this later. > >=20 > > I didn't realize it was zero indexed when I wrote alienware-wmi, > > and I'm guessing the author of dell-wmi-led didn't either. > >=20 > > The reason it's probably working is the ACPI byte code isn't > > actually checking the instance since most times _WDG will only > > call out one instance. >=20 > I confirmed you're correct. Switching instance over to 0 works > properly on an ASM200 (supported by alienware-wmi). Can you check what is the value in the instance_count in _WDG? =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart1587285.rm0S5OEJtb Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAllFWhwACgkQi/DJPQPkQ1IpSgCgiqPrJaNp37t6aVuVxGuFhOvg hXUAn2TlXUWTewI5gI97dEAw6j5a8+1Q =vwPS -----END PGP SIGNATURE----- --nextPart1587285.rm0S5OEJtb--